Move the longest drd tests to Nightly build #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Move_the_longest_drd_tests_to_Nightly_build
branch
from
605408e to
c0eada6
Compare
bratpiorka
reviewed
May 9, 2025
test/test_valgrind.sh
Outdated
| case $TOOL in | ||
| memcheck) | ||
| OPTION="--leak-check=full" | ||
| ;; | ||
| drd) | ||
| OPTION="--tool=drd" | ||
| ;; | ||
| drdnolong) |
There was a problem hiding this comment.
should the naming be reversed? e.g. drdshort = run tests with exclusions?
|
It decreases time of the drd test from 48 minutes to less than 7 minutes. |
ldorau
force-pushed
the
Move_the_longest_drd_tests_to_Nightly_build
branch
3 times, most recently
from
7d60f11 to
4deba20
Compare
Move the longest drd tests to Nightly build. Add the drdshort option to the valgrind script. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Move_the_longest_drd_tests_to_Nightly_build
branch
from
4deba20 to
71fd678
Compare
lukaszstolarczuk
approved these changes
May 9, 2025
|
Duration of the valgrind jobs on the current main branch: Duration of the valgrind jobs with this change: |
bratpiorka
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the longest drd tests to Nightly build (in seconds):
and in minutes:
Add the drdshort option to the valgrind script.
It decreases time of the drd test from 48 minutes to less than 7 minutes.
Duration of the valgrind jobs on the current main branch:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/14930807298/job/41949432868
Duration of the valgrind jobs with this change:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/14930811668/job/41968370046
Checklist