Fix maximum number of arenas in op_initialize() #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lplewa please review |
bratpiorka
reviewed
May 12, 2025
ldorau
force-pushed
the
Fix_maximum_number_of_arenas_in_op_initialize
branch
from
3596017 to
77bd1f6
Compare
bratpiorka
approved these changes
May 12, 2025
lplewa
reviewed
May 12, 2025
src/pool/pool_jemalloc.c
Outdated
| LOG_ERR("Could not create arena."); | ||
| // EAGAIN - means that a memory allocation failure occurred | ||
| // (2 * utils_get_num_cores()) is the required minimum number of arenas | ||
| if (err == EAGAIN && (i >= (2 * utils_get_num_cores()))) { |
There was a problem hiding this comment.
If user set arenas number param, we should create all of them or fail.
Number of arenas greater than 253 causes the "Resource temporarily unavailable" error on a machine with 96 cores. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Fix_maximum_number_of_arenas_in_op_initialize
branch
from
77bd1f6 to
fd7a862
Compare
|
👍 |
lplewa
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Number of arenas greater than 253 causes
the "Resource temporarily unavailable" error
on a machine with 96 cores.
Checklist