Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vcpkg tbb installation #1230

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Apr 1, 2025

Description

Fixes vcpkg tbb installation error on the latest Windows runners with CMake 2.31 installed:

Building tbb[core,hwloc]:[email protected]...
-- Downloading https://github.com/oneapi-src/oneTBB/archive/v2021.11.0.tar.gz -> oneapi-src-oneTBB-v2021.11.0.tar.gz...
-- Extracting source D:/a/unified-memory-framework/unified-memory-framework/build/vcpkg/downloads/oneapi-src-oneTBB-v2021.11.0.tar.gz
-- Using source at D:/a/unified-memory-framework/unified-memory-framework/build/vcpkg/buildtrees/tbb/src/v2021.11.0-0163f51d5f.clean
CMake Warning (dev) at scripts/cmake/vcpkg_find_acquire_program.cmake:70 (cmake_parse_arguments):
  The INTERPRETER keyword was followed by an empty string or no value at all.
  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  arg_INTERPRETER variable rather than setting it to an empty string.
Call Stack (most recent call first):
  scripts/cmake/vcpkg_find_acquire_program.cmake:143 (z_vcpkg_find_acquire_program_find_internal)
  D:/a/unified-memory-framework/unified-memory-framework/vcpkg_installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:104 (vcpkg_find_acquire_program)
  ports/tbb/portfile.cmake:17 (vcpkg_cmake_configure)
  scripts/ports.cmake:170 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at scripts/cmake/vcpkg_find_acquire_program.cmake:30 (cmake_parse_arguments):
  The INTERPRETER keyword was followed by an empty string or no value at all.
  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  arg_INTERPRETER variable rather than setting it to an empty string.
Call Stack (most recent call first):
  scripts/cmake/vcpkg_find_acquire_program.cmake:149 (z_vcpkg_find_acquire_program_find_external)
  D:/a/unified-memory-framework/unified-memory-framework/vcpkg_installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:104 (vcpkg_find_acquire_program)
  ports/tbb/portfile.cmake:17 (vcpkg_cmake_configure)
  scripts/ports.cmake:170 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found external ninja('1.12.1').
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Error:     Command failed: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v
    Working Directory: D:/a/unified-memory-framework/unified-memory-framework/build/vcpkg/buildtrees/tbb/x64-windows-rel/vcpkg-parallel-configure
    Error code: 1

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly

@PatKamin PatKamin requested a review from bratpiorka April 1, 2025 11:47
@PatKamin PatKamin requested a review from a team as a code owner April 1, 2025 11:47
@PatKamin PatKamin force-pushed the fix-tbb-vcpkg branch 3 times, most recently from 6435632 to e3cd241 Compare April 1, 2025 12:22
Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of the --triplet cause it screams about it so long.

@PatKamin
Copy link
Contributor Author

PatKamin commented Apr 1, 2025

Sanitizers failures most probably related with the fix: #1225

@PatKamin
Copy link
Contributor Author

PatKamin commented Apr 1, 2025

@bratpiorka bratpiorka merged commit 25d9074 into oneapi-src:main Apr 2, 2025
577 of 597 checks passed
@PatKamin PatKamin deleted the fix-tbb-vcpkg branch April 2, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants