Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sycl benchmark to sycl compatibility workflow #1226

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

PatKamin
Copy link
Contributor

Description

Add a sycl benchmark script run as an additional sycl compatibility test

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly

Sorry, something went wrong.

@PatKamin PatKamin force-pushed the sycl-bench-compat branch 4 times, most recently from 3fce69a to a6cfee8 Compare March 31, 2025 08:17
@@ -120,3 +122,24 @@ jobs:
echo "---Run build_log test" && ./build_log
echo "---Run parallel_for_range_roundup test" && ./parallel_for_range_roundup
echo "---Run fill_any_size test" && ./fill_any_size

# Run sycl benchmarks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run this on benchmark machine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, extended the Nightly benchmark job instead

@PatKamin PatKamin force-pushed the sycl-bench-compat branch 6 times, most recently from a5b9f79 to 59b2003 Compare April 1, 2025 13:19
run_sycl:
required: false
type: boolean
default: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As to run it only during the Nightly job. However, now I see that there is an advantage of running these always, also on the workflow_dispatch by hand - I'll remove this condition.

@@ -162,6 +186,8 @@ jobs:
--results-dir ${{ github.workspace }}/results-repo
--output-markdown
${{ env.bench_params }}
${{ inputs.run_sycl && '--sycl env.SYCL_DIR' || '' }}
${{ inputs.run_sycl && '--adapter level_zero' || '' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not v2?

@PatKamin PatKamin force-pushed the sycl-bench-compat branch 6 times, most recently from 02b2b2e to 42922bb Compare April 1, 2025 20:07
@PatKamin PatKamin force-pushed the sycl-bench-compat branch 8 times, most recently from 6a305da to fa7decb Compare April 4, 2025 11:44
@PatKamin PatKamin force-pushed the sycl-bench-compat branch from fa7decb to b307fc0 Compare April 4, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants