-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sycl benchmark to sycl compatibility workflow #1226
base: main
Are you sure you want to change the base?
Conversation
3fce69a
to
a6cfee8
Compare
.github/workflows/reusable_sycl.yml
Outdated
@@ -120,3 +122,24 @@ jobs: | |||
echo "---Run build_log test" && ./build_log | |||
echo "---Run parallel_for_range_roundup test" && ./parallel_for_range_roundup | |||
echo "---Run fill_any_size test" && ./fill_any_size | |||
|
|||
# Run sycl benchmarks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run this on benchmark machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, extended the Nightly benchmark job instead
a5b9f79
to
59b2003
Compare
run_sycl: | ||
required: false | ||
type: boolean | ||
default: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As to run it only during the Nightly job. However, now I see that there is an advantage of running these always, also on the workflow_dispatch
by hand - I'll remove this condition.
@@ -162,6 +186,8 @@ jobs: | |||
--results-dir ${{ github.workspace }}/results-repo | |||
--output-markdown | |||
${{ env.bench_params }} | |||
${{ inputs.run_sycl && '--sycl env.SYCL_DIR' || '' }} | |||
${{ inputs.run_sycl && '--adapter level_zero' || '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not v2?
02b2b2e
to
42922bb
Compare
6a305da
to
fa7decb
Compare
fa7decb
to
b307fc0
Compare
Description
Add a sycl benchmark script run as an additional sycl compatibility test
Checklist