[PTX] Enable migration of mma (m16n8k16) #2746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejaX-Alaghari
force-pushed
the
ptx_mma
branch
2 times, most recently
from
2b4c1bd to
6719399
Compare
tomflinda
reviewed
Mar 28, 2025
| /// \param [in] item The sycl::nd_item index space class | ||
| template <typename MulType, typename ABType, typename CDType, typename ItemT> | ||
| __attribute__((optnone)) void | ||
| mma(CDType *d0, CDType *d1, CDType *d2, CDType *d3, ABType a0, ABType a1, |
There was a problem hiding this comment.
According the PTX spec: https://docs.nvidia.com/cuda/parallel-thread-execution/#matrix-multiply-accumulate-operation-using-mma-instruction, there are 11 kinds of shapes for mma:
m8n8k4
m8n8k16
m8n8k32
m8n8k128
m16n8k4
m16n8k8
m16n8k16
m16n8k32
m16n8k64
m16n8k128
m16n8k256
Pls make sure your helper function has the capability to support them besides the shape of "m16n8k16".
There was a problem hiding this comment.
As this is the initial PR, I've added support for the shape used in top apps
Will add support for remaining shapes soon
tomflinda
reviewed
Mar 28, 2025
zhiweij1
reviewed
Mar 28, 2025
TejaX-Alaghari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the migration of mma PTX ASM API