This repository was archived by the owner on Jan 23, 2024. It is now read-only.
run_umls task now uses correct .prop file #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running
bundle exec rake terminology:run_umlsfails (even after setting up a local version of UMLS) because it's looking for a config calledinferno.propthat doesn't exist. This PR updates the rake task argument to use the availableall-active-exportconfig.propconfig, which appears to be the correct name for the config in this repo.New behavior
No new behavior other than addressing this bug.
Code changes
The
terminology:run_umlsrake task now uses the appropriate .prop config file.Testing guidance
With the local terminology service up and running, confirm that you can successfully run the UMLS task.