Self hosting browser extension updates #4494
Open
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
oswinma
approved these changes
Nov 25, 2024
submatrix
reviewed
Dec 1, 2024
| const auth = apiKey ? { Authorization: apiKey } : {} | ||
| return fetch(apiUrl, { |
There was a problem hiding this comment.
I'm not sure it's the best idea to build the url this deep in the call stack. Minimally, I'm seeing that this is causing error messages generated in background.js to print out the wrong url since omnivoreGraphqlURL is hardcoded:
const omnivoreGraphqlURL = "https://api-prod.omnivore.app/api/"
which leads to misleading error messages when debugging the extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides the request URL for users who choose to set their own API URL, otherwise leaves it as is.
Changing the
content-security-policyisn't ideal but I don't think we have another option.Having a look at the rest of the extension it might be possible to get it all working with manifest v3. But this should work now.
I'm not sure how much sanitation of user inputted urls should be done.