Repository navigation
Create admin configuration and display brand icons based on configura… #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
833667e
Create admin configuration and display brand icons based on configura…
pratik-bharodiya 9c8c382
Create a test unit class
pratik-bharodiya 8bd7396
Create a test unit class
pratik-bharodiya eb4929c
Resolve git-copilot suggestion
pratik-bharodiya bfbe3fe
refactor the variable name in complete flow
pratik-bharodiya 978b021
Minor space issue
pratik-bharodiya d390d1c
git co-pilot issue fixed
pratik-bharodiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <?php | ||
|
|
||
| namespace Omise\Payment\Model\Source; | ||
|
|
||
| use Magento\Framework\Option\ArrayInterface; | ||
|
|
||
| class CardBrandIcon implements ArrayInterface | ||
| { | ||
| /** | ||
| * Return array of supported card brand icons | ||
| * @return array | ||
| */ | ||
| public function toOptionArray() | ||
| { | ||
| return [ | ||
| [ | ||
| 'value' => 'visa', | ||
| 'label' => __('Visa'), | ||
| ], | ||
| [ | ||
| 'value' => 'mastercard', | ||
| 'label' => __('Mastercard'), | ||
| ], | ||
| [ | ||
| 'value' => 'amex', | ||
| 'label' => __('American Express'), | ||
| ], | ||
| [ | ||
| 'value' => 'jcb', | ||
| 'label' => __('JCB'), | ||
| ], | ||
| [ | ||
| 'value' => 'diners', | ||
| 'label' => __('Diners Club'), | ||
| ], | ||
| [ | ||
| 'value' => 'discover', | ||
| 'label' => __('Discover'), | ||
| ], | ||
| ]; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?php | ||
|
|
||
| namespace Omise\Payment\Test\Unit\Model\Config; | ||
|
|
||
| use Omise\Payment\Model\Config\Cc; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class CcConfigTest extends TestCase | ||
| { | ||
| /** | ||
| * @covers \Omise\Payment\Model\Config\Cc::getSupportedCardIcons | ||
| */ | ||
| public function testGetSupportedCardIconsReturnsConfiguredCommaSeparatedValues(): void | ||
| { | ||
| $config = $this->createConfigMock('visa,mastercard,amex'); | ||
|
|
||
| $this->assertSame(['visa', 'mastercard', 'amex'], $config->getSupportedCardIcons()); | ||
| } | ||
|
|
||
| /** | ||
| * @covers \Omise\Payment\Model\Config\Cc::getSupportedCardIcons | ||
| * @dataProvider emptyConfigValueProvider | ||
| */ | ||
| public function testGetSupportedCardIconsReturnsEmptyArrayWhenNoIconsAreConfigured($emptyValue): void | ||
| { | ||
| $config = $this->createConfigMock($emptyValue); | ||
|
|
||
| $this->assertSame([], $config->getSupportedCardIcons()); | ||
| } | ||
|
|
||
| public static function emptyConfigValueProvider(): array | ||
| { | ||
| return [ | ||
| 'null' => [null], | ||
| 'empty string' => [''], | ||
| ]; | ||
| } | ||
|
|
||
| private function createConfigMock($value): Cc | ||
| { | ||
| $config = $this->getMockBuilder(Cc::class) | ||
| ->disableOriginalConstructor() | ||
| ->onlyMethods(['getValue']) | ||
| ->getMock(); | ||
|
|
||
| $config->expects($this->once()) | ||
| ->method('getValue') | ||
| ->with('supported_card_icons', Cc::CODE) | ||
| ->willReturn($value); | ||
|
|
||
| return $config; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?php | ||
|
|
||
| namespace Omise\Payment\Test\Unit\Model\Source; | ||
|
|
||
| use Omise\Payment\Model\Source\CardBrandIcon; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class CardBrandIconTest extends TestCase | ||
| { | ||
| /** | ||
| * @covers \Omise\Payment\Model\Source\CardBrandIcon::toOptionArray | ||
| */ | ||
| public function testToOptionArrayReturnsSupportedCardBrandIcons(): void | ||
| { | ||
| $source = new CardBrandIcon(); | ||
| $options = $source->toOptionArray(); | ||
|
|
||
| $this->assertSame( | ||
| [ | ||
| ['value' => 'visa', 'label' => 'Visa'], | ||
| ['value' => 'mastercard', 'label' => 'Mastercard'], | ||
| ['value' => 'amex', 'label' => 'American Express'], | ||
| ['value' => 'jcb', 'label' => 'JCB'], | ||
| ['value' => 'diners', 'label' => 'Diners Club'], | ||
| ['value' => 'discover', 'label' => 'Discover'], | ||
| ], | ||
| array_map( | ||
| static function (array $option): array { | ||
| return [ | ||
| 'value' => $option['value'], | ||
| 'label' => (string) $option['label'], | ||
| ]; | ||
| }, | ||
| $options | ||
| ) | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.