chore(config): default to Opus 4.8 (claude-opus-4-7 -> claude-opus-4-8)#39
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughWalkthroughThis pull request updates the default Claude model version from Opus 4.7 to Opus 4.8 throughout the codebase. Changes span runtime schema defaults, contract and reference documentation, and test assertions reflecting the new model as the primary default. ChangesClaude Opus 4.8 upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR completes the default Claude model migration from claude-opus-4-7 to claude-opus-4-8 by updating the engine defaults and aligning tests and documentation that assert the current default.
Changes:
- Update
DEFAULT_CONFIGto defaultmodels.primarytoclaude-opus-4-8and move the default ClaudepriceTableentry toclaude:claude-opus-4-8(with updated lookup-date comment). - Update the two tests that assert
DEFAULT_CONFIG-derived defaults to expectclaude-opus-4-8. - Update docs/contracts, docs/references, and
CLAUDE.mdto reflectclaude-opus-4-8as the default and update related examples.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/config-budgets.test.ts | Updates default Claude priceTable assertion and pricing lookup-date comment to match the new default. |
| tests/cli-init.test.ts | Updates init-scaffolded config default-model assertion to claude-opus-4-8. |
| src/providers/capabilities.ts | Updates priced-model comment to reference Opus 4.8 (model-level pricing). |
| src/config/schema.ts | Switches DEFAULT_CONFIG.models.primary and default priceTable key to Opus 4.8; updates lookup-date comment and example key in docs comment. |
| docs/references/provider-contract.md | Updates narrative description of shipped Claude model defaults to Opus 4.8. |
| docs/references/budgets.md | Updates YAML example, keying example, lookup date, and default-model table row to Opus 4.8. |
| docs/references/agent-skill-format.md | Updates example frontmatter model to claude-opus-4-8. |
| docs/contracts/VERIFY.md | Updates example modelPolicy.primary to Opus 4.8. |
| docs/contracts/SCIENTIST.md | Updates example modelPolicy.primary to Opus 4.8. |
| docs/contracts/REVIEW_PANEL.md | Updates example advisory reviewer modelPolicy to Opus 4.8. |
| docs/contracts/COMPANY.md | Updates examples and resolved-registry table rows to use Opus 4.8 where applicable. |
| docs/contracts/BUILD.md | Updates example modelPolicy.primary to Opus 4.8. |
| CLAUDE.md | Updates rule 4 to state claude-opus-4-8 as the primary model default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7f426a953
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Lookup date: 2026-05-29 (Opus 4.8 is the default; $5/$25 unchanged from 4.7) | ||
| priceTable: Object.freeze({ | ||
| 'claude:claude-opus-4-7': Object.freeze({ inputPerMTok: 5, outputPerMTok: 25 }), | ||
| 'claude:claude-opus-4-8': Object.freeze({ inputPerMTok: 5, outputPerMTok: 25 }), |
There was a problem hiding this comment.
When a project explicitly pins claude-opus-4-7 via models.primary, company.<role>.model, or agent frontmatter but relies on the default budget table, this replacement makes USD telemetry disappear for that still-supported model: estimateCostUSD/actualCostUSD resolve only the exact claude:<model> key and Claude has no provider-level costPerMTok fallback. Since the comment says the 4.8 price is unchanged from 4.7, keeping both keys preserves costEstimateUSD/costActualUSD for users who downgrade or haven't migrated yet.
Useful? React with 👍 / 👎.
Complete the half-done default-model migration that was sitting RED in the
working tree. claude-opus-4-8 is GA (launched 2026-05-28, $5/$25, same price
as 4.7) and is the recommended default per rule 4.
Engine:
- src/config/schema.ts: DEFAULT_CONFIG.models.primary and the priceTable key
claude:claude-opus-4-8; lookup-date comment corrected to 2026-05-29 (4.8
launched after the old 2026-05-01 lookup; price unchanged).
- src/providers/capabilities.ts: priced-model comment.
Tests (rule 22 RED-first): cli-init and config-budgets are the only tests
that read DEFAULT_CONFIG-derived values. Flipped them to assert 4-8, watched
them fail for the right reason, then landed the engine change to green.
CLI config docs that assert the current default: contracts/{BUILD,COMPANY,
REVIEW_PANEL,SCIENTIST,VERIFY}.md, references/{agent-skill-format,budgets,
provider-contract}.md.
Scope discriminator (migrate only current-default assertions). Deliberately
left, each a noted exclusion: self-consistent test data using 4-7 as
arbitrary still-live model data (propagation/cost/echo tests); historical
debate transcripts and authorship attributions; recorded demo events.jsonl;
code-oz-gui (separate sub-project, internally consistent).
Cross-family review: Codex gpt-5.5 xhigh -- fix-first (two stale lookup-date
siblings) then push after fix. 3810 pass / 2 skip / 0 fail; typecheck clean.
omerakben
force-pushed
the
feat/opus-4-8-default
branch
from
e7f426a to
6ad0bbb
Compare
What
Completes the half-done Opus 4.7 -> 4.8 default-model migration that was sitting uncommitted and RED in the working tree. `claude-opus-4-8` is GA (launched 2026-05-28, $5/$25, same price as 4.7) and is the recommended default per CLAUDE.md rule 4.
Changes (13 files)
Scope
Migrated only sites that assert the current default. Left untouched (each a deliberate, noted exclusion): self-consistent test data using 4-7 as arbitrary still-live model data, historical debate transcripts, recorded demo `events.jsonl`, and all of `code-oz-gui/`.
Verification
Summary by CodeRabbit