Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral CI run API #80

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Ephemeral CI run API #80

wants to merge 6 commits into from

Conversation

frcepeda
Copy link
Member

@frcepeda frcepeda commented Apr 30, 2022

La idea es poder llamar a omegaup.com/grader/ci/ephemeral/ con tu zip feliz y pues usar lo que ya está para que conteste. El report.json basta, y pues si no entiendo mal como son ephemeral runs podrías hacerles browse con tu navegador, no? (Que eso lo extraño mil de omegaUp-deploy v1)

Faltan tests, soporte de output generation, algún tipo de rate limiting—probablemente basta con pedir API token y llamar al frontend para contar, no?

Como quiera, quejas, comentarios o sugerencias 👀

@frcepeda frcepeda changed the title CI zip request API Ephemeral CI run API Apr 30, 2022
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #80 (bc8c91d) into main (73a71c1) will decrease coverage by 0.24%.
The diff coverage is 30.59%.

❗ Current head bc8c91d differs from pull request most recent head 38fc037. Consider uploading reports for the commit 38fc037 to get more accurate results

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   41.13%   40.88%   -0.25%     
==========================================
  Files          25       25              
  Lines        6681     6746      +65     
==========================================
+ Hits         2748     2758      +10     
- Misses       3676     3728      +52     
- Partials      257      260       +3     
Impacted Files Coverage Δ
runner/ci/ci.go 52.71% <ø> (ø)
cmd/omegaup-grader/ci.go 40.91% <30.59%> (-3.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a71c1...38fc037. Read the comment docs.

var problemFiles *common.ProblemFiles

if report.IsEphemeral {
r.ParseMultipartForm((base.Byte(150) * base.Mebibyte).Bytes())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo poner estos en un lugar más mono, pero no sé donde 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esto va a timeoutear bien recio :/ tenemos problemas para subir zips grandes, así que esto va a estar súper flaky.

además que andar mandando zips de más de 100 MiB nos va a salir bastante caro ^^;; así que realísticamente sólo podríamos permitir como uno de estos por minuto, lo cual suena medio inútil para fines de CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants