Repository navigation
Folded corner, page-edge strip and eraser fixes from the owner's page comments - #541
Merged
Merged
Conversation
The patch under the fold was a grey-beige that read as a square pasted on the page. It now ends in the page's own colour and is only lightly shaded at the crease; the flap's shadow is what makes it read as a fold. A browser test checks the colours against the page's paper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The earlier report (#202) found a corner drawn in the page's own colour read as a flat square; this morning's found the grey read as a patch. The page under the fold is now only just darker than the page, which both tests hold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shading that shows when you hover an outer page edge ran the height of the window: it began below the head of the book and ran on under the pages, with square corners. It now stands on the paper, rounded as the paper is, and reaches the head of the book along the page edges beside the fold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…reen Two questions from the owner's comments on the app's page, each written up where it belongs with the options to build and try. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…full screen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On a busy machine the list could reach the script a moment after it read the pipe, so a push that only deleted a branch was taken as 'no input' and the script's own test failed now and then. It now reads until git closes the pipe. A new test hands the list over 300 ms late. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nder the pointer Two questions from the owner's page comment on the verse drawer, logged in the verse drawer's decision record with what would answer each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the owner's page comment on the Share button, logged as question 3 in the verse drawer's decision record. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner asked why the eraser sat beside Undo rather than in the tool bar. On a computer it is now the last tool in the row, picked like the others (E still works). Beside Undo stays as a choice in the info panel, under "Where the eraser sits". A phone keeps it beside Undo: its bar has no room. Tests: the eraser spec checks both places; the specs that count the tools now count it on a computer and an iPad held sideways. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two page comments from the owner, logged as open questions: - full screen keeps a small dock of tools that opens under the pointer (a third option beside the two already listed); - the app gets pages of its own, switched from a bottom row: the mushaf, settings, and a developer page only a laptop build shows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the eraser among the tools, the narrowest computer window no longer had room for the highlighter's pens, and picking it slid every tool 16px (caught by the narrowest-window test in notes.spec). With a mouse the tool buttons are now 40px wide instead of a fingertip's 44px; touch screens keep 44px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and backlog entries from the owner's comments on the app's pages (2026-11-07).
Fixed
Added to the backlog as open questions
Every fix comes with a test. The full set of checks passed locally before the push.
🤖 Generated with Claude Code