Enable resolve_binds_by_sym for high XF86 keycodes - #10577
Open
fresh3nough wants to merge 1 commit into
Open
Conversation
Hyprland defaults input:resolve_binds_by_sym to false and matches binds via keysym→keycode reverse lookup. XF86TouchpadToggle sits at XKB keycode 538 (evdev 530), above the classic 255 ceiling, so the stock XF86Touchpad* binds in bindings/media.lua never fire. Ship resolve_binds_by_sym = true in default/hypr/input.lua so those keysym binds resolve. Live session before the change reported bool: false / set: false while the binds were registered. Fixes omacom#10449 Signed-off-by: fresh3nough <anonwurcod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10449.
Stock touchpad binds in
default/hypr/bindings/media.luaregisterXF86TouchpadToggle/On/Off, but Hyprland defaultsinput:resolve_binds_by_symtofalse. With that default, binds are matched through a keysym→keycode reverse lookup that does not reach XKB keycode 538 (evdevKEY_TOUCHPAD_TOGGLE= 530). The binds stay registered and dead.Related open PR #10539 sets the same option without tests or the issue trail in-tree. This PR adds the default, documents why next to the option, and locks it with a shell test.
Change
default/hypr/input.lua:Evidence
Bug reproduced (this machine, pre-change)
Binds present, option unset → default false → high XF86 keysyms never match (issue reporter also verified with
evtest/ notify probe).Fix validated
Test plan
resolve_binds_by_symfalse while Touchpad binds registeredbash test/shell.d/resolve-binds-by-sym-test.shbash test/shell.d/hyprland-keyboard-layout-test.sh