Add safety auto-dismiss duration and shorter timeout for launch OSD - #10541
Open
oscarbol09 wants to merge 1 commit into
Open
Add safety auto-dismiss duration and shorter timeout for launch OSD#10541oscarbol09 wants to merge 1 commit into
oscarbol09 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launch feedback toast shown by \shell/services/AppLibrary.qml\ passed \duration: 0\ when displaying via \omarchy-shell osd show. Setting duration to 0 completely disabled \Osd.qml's auto-dismiss timer (\hideTimer).
When launching web applications or applications that delegate to existing browser instances, window-count changes are not always detected by \ToplevelManager\ in time, or signals can be dropped, leaving the notification permanently frozen on screen over the launched application. Furthermore, the fallback \launchTimeout\ was 15 seconds long.
This passes a 3500ms safety duration to the OSD and lowers \launchTimeout\ to 5000ms, ensuring the notification always clears cleanly even if toplevel events fail to fire.
Fixes #10487