Skip to content

[Security] Keep the 1Password lock flock out of world-writable /tmp - #10503

Open
Chessing234 wants to merge 1 commit into
omacom:quattrofrom
Chessing234:security/1password-lock-runtime
Open

[Security] Keep the 1Password lock flock out of world-writable /tmp#10503
Chessing234 wants to merge 1 commit into
omacom:quattrofrom
Chessing234:security/1password-lock-runtime

Conversation

@Chessing234

Copy link
Copy Markdown
Contributor

Summary

  • omarchy system lock flocked ${XDG_RUNTIME_DIR:-/tmp}/omarchy-1password-lock.lock
  • A local user who held that path in /tmp made flock -n || exit 0 skip 1password --lock
  • Stage the flock under $XDG_RUNTIME_DIR (or a 0700 /tmp/omarchy-$UID fallback). If the private lock file cannot be created, still lock

Test plan

  • bash test/shell.d/system-lock-test.sh
  • Lock a session with 1Password running and confirm the flock is not /tmp/omarchy-1password-lock.lock

Made with Cursor

@Chessing234

Copy link
Copy Markdown
Contributor Author

@dhh @ryanrhughes ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant