Coordinate Hermes graphical setup and native updates - #10443
Conversation
|
Omabot review: no remaining source blockers at Claude Opus 5 in Claude Code, at default effort through Omabot’s subscription workflow, and an independent GPT-6 Codex review at xhigh agree on the final source. Setup waits for the native desktop and prompted CLI before reporting success; older packages are detected without forwarding unsupported flags to Electron. Cleanup requires proof of the old Omarchy CLI’s ownership. Removal preserves foreign launchers, local source changes, unpublished history, linked worktrees and user data by default. Seven focused Hermes suites passed with 134+ assertions, alongside targeted mutation checks. The aggregate suite still has three failures—bin-style’s existing OpenClaw check, launch-about, and runtime-smoke—which each reproduce on untouched base Separate runtime validation confirmed fresh installation of the coordinated package, correct desktop registration with a competing CLI on PATH, repeated setup without changes, successful CLI update, and a real in-app update/rebuild/relaunch from 🤖 Generated by GPT-6 in Codex/T3 Code. Reviewed by Claude Opus 5 at default effort through Omabot and GPT-6 Codex at xhigh. |
smfworks
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Reviewed (comment) — no source blocker that should stop the package-first plan. One product hole and one merge conflict.
PR: #10443 — Finish Hermes native setup before launching the app
Package: omacom/omarchy-pkgs#325 must ship first (agreed).
Warning
HERMES_HOMEinheritance. Install, CLI setup, theme handoff, and remove all honor${HERMES_HOME:-$HOME/.hermes}. That is correct for an explicit custom data home (and the tests cover a path with spaces). It is wrong if Install > AI / Remove > AI is invoked from a Hermes profile session, whereHERMES_HOMEis~/.hermes/profiles/<name>. That would provision or delete the profile tree instead of the machine install. Menu launch viaomarchy-launch-floating-terminal-with-presentationis a clean env and is fine. Pin the Omarchy verbs to$HOME/.hermesunless the caller is clearly not a profile directory (or document that Install > AI must not run from a profile shell).
Suggestion
- Conflict with #10460. That PR only swaps
command -v gum→omarchy-cmd-present gumin the Hermes and OpenClaw removers. This PR rewrites the Hermes gum line. Merge #10460 first (OpenClaw is otherwise still failing bin-style); rebase this so Hermes does not bringcommand -vback.
Looks good
- Waiting for
hermes-desktop --install/--checkbefore launch instead of racing first-run Electron. - Predecessor receipt +
owns_predecessorso mise cleanup is not “rm whatever is named hermes”. - Remove keeps dirty checkouts, extra worktrees, unpublished history, and customized wrappers; user data still defaults to no.
- Older packages detected via
pacman -Qlqrather than forwarding unknown flags into Electron. - Namespace sandbox (
--disable-setuid-sandboxwhenunshareworks) is the right Omarchy path; do not add--no-sandboxhere.
I did not re-run the 134 Hermes assertions; relying on the stated local results and that quattro still has the three unrelated aggregate failures.
|
Addressed the profile-home finding in Install, CLI setup/readiness/cleanup, theme handoff, and removal now share a home resolver before operating. An inherited Independent GPT-6 Codex review at xhigh found no confirmed blockers and exercised the actual install/CLI/package and removal/CLI chains in disposable fixtures. All eight focused Hermes suites pass with 140 assertions, and seven deliberate mutations are caught. The full suite completes with the same three previously reproduced baseline failures: bin-style, launch-about, and runtime-smoke. Omabot is being rerun on these new commits next. On #10460: it is still open, and this PR is currently mergeable against 🤖 Generated by GPT-6 in Codex/T3 Code. Reviewed by GPT-6 Codex at xhigh. |
|
Omabot final review: no confirmed source blockers at Claude Opus 5 in Claude Code, at default effort through Omabot’s subscription workflow, and the independent GPT-6 Codex review at xhigh both found the profile-resolution change consistent with Hermes’ supported root/profile layout. Setup, readiness, cleanup, theme handoff, and removal select the shared installation home while preserving explicit custom roots and existing ownership safeguards. No further source changes were required. All eight focused Hermes suites passed with 140 reported assertions, and seven targeted mutation checks caught the removed fixes. The independent review also exercised the actual command chain in disposable fixtures. The full suite completed with exactly the same three previously reproduced baseline failures: bin-style, launch-about, and runtime-smoke. No hosted checks are reported for this PR. The real rebuilt package additionally passed profile-session readiness and warm setup; GUI and native theme activation from a profile were not rerun in this follow-up. Ship the coordinated package first; both PRs are required for the complete profile fix. The #10460 overlap is addressed in the preceding reply: retain the direct 🤖 Generated by GPT-6 in Codex/T3 Code. Reviewed by GPT-6 Codex at xhigh and Claude Opus 5 at default effort through Omabot. |
Wait for the package to finish the writable runtime and desktop before launch or legacy CLI cleanup. Preserve installation ownership through retries and remove only unchanged, published runtime work while retaining user data by default. Co-Authored-By: GPT-6 Codex (xhigh) <noreply@openai.com>
61fb0b0 to
216dd06
Compare
AI -> Hermes should install the package in the menu terminal, open the desktop immediately, and let Hermes perform first-run installation inside the app. The earlier synchronous
--nowhandoff built the runtime and desktop before showing the window.Use a metadata-only check for the prebuilt package, then launch its entry point and wait separately for theme activation. Explicit CLI setup remains available through
omarchy-install-hermes-cli --now. Native desktop and CLI readiness, shared profile homes, ownership-based predecessor cleanup, and preservation of user data and custom installations remain coordinated with the package.Requires the
hermes-desktop 2026.8.31-2correction in omacom/omarchy-pkgs#334. Package PR #325 has merged, but its installer-only release does not provide the intended graphical setup; the new menu check rejects that payload without executing it. Publish the corrected package before this integration.This PR remains draft while the final release-2 bootstrap, app/CLI update, and browser-session validation finish. Focused Hermes and CLI tests pass. Independent review and actual Omabot review will be reconciled against the final coordinated heads.
🤖 Generated by GPT-6 in Codex/T3 Code. Independent GPT-6 Codex review at xhigh is in progress.