Canonicalize install device paths before invoking archinstall - #142
Open
jonbng wants to merge 1 commit into
Open
Canonicalize install device paths before invoking archinstall#142jonbng wants to merge 1 commit into
jonbng wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses Archinstall 4.4’s device lookup behavior by canonicalizing configured install device paths (e.g., /dev/disk/by-id/... symlinks) into their resolved kernel device paths (e.g., /dev/vda) before writing the Archinstall configuration, preventing Archinstall from silently dropping disk layouts.
Changes:
- Deep-copy the user configuration into a dedicated Archinstall configuration, then canonicalize install device paths and validate they exist and are block devices.
- Preserve the original (stable) device alias in the persistent
user_configurationfor diagnostics/cleanup while ensuring Archinstall receives canonical device paths. - Adjust deferred-provisioning encryption password injection to explicitly mirror the effective passphrase into the persistent configuration (now that configurations are separated), and add unit tests for both canonicalization and missing-device failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/unit/test_provisioning_state.py | Adds unit tests ensuring stable device aliases remain in persistent config while Archinstall receives canonical paths; adds coverage for missing install devices. |
| configs/airootfs/usr/share/omarchy-iso/orchestrator/context.py | Separates Archinstall config via deep copy, canonicalizes/validates install device paths, and preserves deferred-provisioning encryption password behavior across the split configs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Autoinstall configurations may identify the target disk using a stable path such as
/dev/disk/by-id/....Archinstall 4.4 indexes devices by their canonical kernel paths, such as
/dev/vda. When given a valid symlink, it can silently omit the disk layout, leaving/mnton the live filesystem and eventually causing installation to fail due to insufficient space.Solution
Testing
/dev/disk/by-id/virtio-omarchy-lab.