Installer fixes: dual-boot free-space + full-disk (#3 #115 #127 #130 #137) - #140
Open
nightdevil00 wants to merge 1 commit into
Open
Installer fixes: dual-boot free-space + full-disk (#3 #115 #127 #130 #137)#140nightdevil00 wants to merge 1 commit into
nightdevil00 wants to merge 1 commit into
Conversation
…top WIP Installer fixes: - Free-space install on a different disk ([NTFS][free space]): the configurator now states it always creates its own EFI + root, and clear_stale_signatures() retries the wipefs so a transient busy device no longer aborts a reinstall (omacom#3). - Full NVRAM blocks the Limine boot entry (omacom#127): capture efibootmgr's reason, purge dangling entries (Windows/live untouched), retry once, then fall back to \EFI\BOOT\BOOTX64.EFI + enable Limine fallback. - Full-disk stale LUKS header aborts archinstall's wipe (omacom#137): the cleanup script wipes partition + disk signatures itself before archinstall. - cryptsetup close "Device root is still in use" race (omacom#130): force-close stray mappings and retry, scoped to the busy-device message. - archinstall scans a LUKS partition as btrfs and crashes (omacom#115): guard get_btrfs_info() against crypto_LUKS during partitioning. Tests added: test_nvram_fallback.py, cleanup-disk-wipe-test.sh Plans: installer-fixes-dual-boot-and-full-disk.md, installer-fixes-PR-BODY.md Also bundles the current live-desktop working tree (nvidia live install, omarchy-live-boot service, systemd/modprobe units, profiledef/grub/syslinux updates). archiso submodule left at the published 424e781.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installer fixes: dual-boot free-space + full-disk installers
Closes #3, #115, #127, #130, #137.
Seven installer defects across both install workflows, each fixed so a failure
degrades to the next mechanism instead of aborting the install, and none
changes the standard (non-broken) path.
Dual-boot free-space (
[NTFS][free space])ESP + root in the selected gap (it never touches Windows' ESP/ext4). The disk
configurator now says so on-screen, removing the mis-targeting that aborted
installs on a second disk.
wipefs -afraced udev and aborted the reinstall. New retried,error-tolerant
clear_stale_signatures()(up to 3×, returns 0 on failure)replaces it in
run_partition_execute.efibootmgr --createfailureused to discard the real error and either roll back or abort. Now the reason is
captured, dangling entries are purged (Windows/live untouched), the create is
retried once, and on final failure Omarchy installs the
\EFI\BOOT\BOOTX64.EFIfallback, enables Limine's fallback, keeps the pacmanhook in sync, and
validate_bootaccepts the missing entry only when thefallback exists.
Full-disk
omarchy-iso-cleanup-disknow wipes partition + disk signatures itself(retried, best-effort) after releasing holders, so archinstall's fragile
per-partition wipe is replaced by a clean create.
cryptsetup close"Device root is still in use" race (Omarchy 4.0.1 install intermittently fails with Device root is still in use #130). The adapter'sexisting udev-race retry now also recognizes the busy-device close message,
force-closes stray
cryptmappings, and retries — scoped to that exact messageso genuine failures are still not looped.
get_btrfs_info()is wrapped (try/finally-restored) to skipcrypto_LUKSdevices during the partitioning operation, suppressing the bogus
"wrong fs type, bad superblock" mount. If the archinstall symbol can't be
found the patch self-disables and behaves as before.
Tests
test/unit/test_nvram_fallback.py— Install fails on old UEFI when efibootmgr refuses to create a boot entry, and the reason is discarded #127 (uuid parsing, dangling-vs-livereclaim,
_NvramWriteErrorwith "No space left on device").test/unit/cleanup-disk-wipe-test.sh— Full Install aborts when the target disk already holds a LUKS partition #137 (stale signature wiped on image,clean no-op, busy device tolerated by the call site).
All Python and shell unit tests pass.
Notes for reviewers
partitioning operation (restored in
finally). Open to alternatives if you'drather pin a specific archinstall version.
archinstall's old abort for a new one.