Skip to content

Don't crash when no installable drive is detected - #117

Open
szpoont wants to merge 1 commit into
omacom:quattrofrom
szpoont:fix/configurator-no-drive
Open

Don't crash when no installable drive is detected#117
szpoont wants to merge 1 commit into
omacom:quattrofrom
szpoont:fix/configurator-no-drive

Conversation

@szpoont

@szpoont szpoont commented Aug 22, 2026

Copy link
Copy Markdown

disk_form handed an empty list to 'gum choose' when no disk was found, which aborts with a no-options error. Scan inside a loop and, if no drives are detected, prompt to rescan for a hot-plugged drive or abort cleanly instead of crashing.

fixes omacom/omarchy#7719

disk_form handed an empty list to 'gum choose' when no disk was
found, which aborts with a no-options error. Scan inside a loop and,
if no drives are detected, prompt to rescan for a hot-plugged drive
or abort cleanly instead of crashing.

Assisted-by: pi.dev (hy3)
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown

Greptile Summary

The PR prevents disk selection from invoking gum choose without options and allows hot-plugged drives to be discovered without restarting the installer.

  • Moves installable-drive discovery into a rescan loop.
  • Offers explicit rescan and clean-abort actions when no eligible drive exists.
  • Preserves the existing disk formatting and selection behavior once a drive is found.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issue identified.

The empty-drive state now reaches an explicit rescan or clean-abort prompt, while successful scans continue through the existing disk-option construction and selection flow.

Important Files Changed

Filename Overview
configs/airootfs/root/configurator Adds a sound no-drive rescan/abort loop while retaining boot-device exclusion and the existing disk-selection contract.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Scan installable drives] --> B{Any eligible drives?}
  B -- No --> C{Rescan or abort?}
  C -- Rescan --> A
  C -- Abort --> D[Exit installer cleanly]
  B -- Yes --> E[Build disk options]
  E --> F[Choose install disk]
  F --> G[Store selected disk]
Loading

Reviews (1): Last reviewed commit: "Don't crash when no installable drive is..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Omarchy Installation System Disk Missing Failure Messaging Improvement

1 participant