Don't crash when no installable drive is detected - #117
Open
szpoont wants to merge 1 commit into
Open
Conversation
disk_form handed an empty list to 'gum choose' when no disk was found, which aborts with a no-options error. Scan inside a loop and, if no drives are detected, prompt to rescan for a hot-plugged drive or abort cleanly instead of crashing. Assisted-by: pi.dev (hy3)
Greptile SummaryThe PR prevents disk selection from invoking
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issue identified. The empty-drive state now reaches an explicit rescan or clean-abort prompt, while successful scans continue through the existing disk-option construction and selection flow.
|
| Filename | Overview |
|---|---|
| configs/airootfs/root/configurator | Adds a sound no-drive rescan/abort loop while retaining boot-device exclusion and the existing disk-selection contract. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Scan installable drives] --> B{Any eligible drives?}
B -- No --> C{Rescan or abort?}
C -- Rescan --> A
C -- Abort --> D[Exit installer cleanly]
B -- Yes --> E[Build disk options]
E --> F[Choose install disk]
F --> G[Store selected disk]
Reviews (1): Last reviewed commit: "Don't crash when no installable drive is..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disk_form handed an empty list to 'gum choose' when no disk was found, which aborts with a no-options error. Scan inside a loop and, if no drives are detected, prompt to rescan for a hot-plugged drive or abort cleanly instead of crashing.
fixes omacom/omarchy#7719