Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements mode UV nano for air conditioner RAC_056905_WW #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonasrodrigues93
Copy link

@jonasrodrigues93 jonasrodrigues93 commented Sep 22, 2023

Summary

This pull request implements a new mode called UV Nano for air conditioner. This mode utilizes an ultraviolet light to eliminate biological organisms. For more information, please refer to LG's UV Nano Technology.

Entity

Create a switch entity to control the UV Nano mode.

Tests

I have tested this on my air conditioner with the following scenarios and results:

  • Scenario: Add device on Home Assistant via integration

    • Expected: A new entity called "Air UV Nano" is created.
  • Scenario: Turn on from Home Assistant

    • Expected: Activate UV Nano mode.
  • Scenario: Turn off from Home Assistant

    • Expected: Turn off UV Nano mode on the air conditioner.
  • Scenario: Turn on from IR control

    • Expected: Update status on Home Assistant.
  • Scenario: Turn off from IR control

    • Expected: Update status on Home Assistant.

All scenarios have passed successfully.

Since this is my first time creating or contributing to a custom component, I would greatly appreciate a code review or any suggestions to further improve this pull request.

Copy link
Owner

@ollo69 ollo69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, but seems that some checks are missing:

  • you should check that device support this feature, I think that not all LG AC device have UV Mode
  • you should check that device is in valid status to enable this mode (e.g. probably does not mae sense enable this mode when AC is off)

Take a look to Jet Mode implementation to understand what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants