Add select e2e test to demo issue when select
within include
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thanks for the awesome project!
I found an issue in my production code so here is the e2e test to reproduce it.
When I select only some fields in a nested table, and the
select
clause is within anotherinclude
clause, this bug happens. It doesn't automatically filter the deleted nested items any more. If I explicit select thedeleted
field, then it works as expected.If you run this test, you will see
findFirst with include and select
is failed, butfindFirst with include and select deleted field
is passed.Failed test:
I suspect it's due to this part of the code, as it skips the recursion:
prisma-extension-soft-delete/src/lib/helpers/createParams.ts
Lines 416 to 420 in b64da3e
But I'm not sure yet what's the right fix, or if there are any other pitfalls ahead.