Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deb icon #1372

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Fix deb icon #1372

merged 4 commits into from
Feb 17, 2025

Conversation

IrishBruse
Copy link
Collaborator

@IrishBruse IrishBruse commented Feb 15, 2025

This fixes the deb .desktop file not sure why it wasnt working and app image still works fine
image

Tested by uninstalling and then reinstalling to verify

@oliverschwendener
Copy link
Owner

oliverschwendener commented Feb 16, 2025

Thanks! Never realized that it didn't work. I think it works now because of the size in the file name. According to https://www.electron.build/linux#icon the icon file name must contain the size:

The icon filename must contain the size (e.g. 32x32.png) of the icon.

Is there a reason why you want to change the app icon from "app-icon-dark.png" to "app-icon-dark-transparent.png"?

@IrishBruse
Copy link
Collaborator Author

Windows uses that icon right just was trying to to be consistent plus I don't really see icons with backgrounds much on linux

@oliverschwendener
Copy link
Owner

oliverschwendener commented Feb 17, 2025

It doesn't seem to work for me (using Ubuntu). Am I missing something?

image

I ran:

$ npm install
$ npm run build
$ npm run package

@IrishBruse
Copy link
Collaborator Author

IrishBruse commented Feb 17, 2025

Its the icon it adds in the "start menu" the deb file can't have an icon not sure why the app image doesn't have it in whatever that filemanager is, on Linux mint the app image get the icon for me before and after my changes 🤔

@IrishBruse
Copy link
Collaborator Author

Before
image

After
image

Copy link
Owner

@oliverschwendener oliverschwendener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@IrishBruse IrishBruse enabled auto-merge February 17, 2025 20:52
@IrishBruse IrishBruse merged commit 14b2a02 into main Feb 17, 2025
3 checks passed
@IrishBruse IrishBruse deleted the fix-deb-icon branch February 17, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants