-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deb icon #1372
Fix deb icon #1372
Conversation
Thanks! Never realized that it didn't work. I think it works now because of the size in the file name. According to https://www.electron.build/linux#icon the icon file name must contain the size: The icon filename must contain the size (e.g. 32x32.png) of the icon. Is there a reason why you want to change the app icon from "app-icon-dark.png" to "app-icon-dark-transparent.png"? |
Windows uses that icon right just was trying to to be consistent plus I don't really see icons with backgrounds much on linux |
Its the icon it adds in the "start menu" the deb file can't have an icon not sure why the app image doesn't have it in whatever that filemanager is, on Linux mint the app image get the icon for me before and after my changes 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This fixes the deb .desktop file not sure why it wasnt working and app image still works fine

Tested by uninstalling and then reinstalling to verify