Fix/production readiness audit - #135
Merged
Merged
Conversation
Glide's Rust-backed clients have no execute_command seam to patch, so wrap the client itself. Restores the cross-backend WrongTypeError contract the other adapters already honour.
GlideClusterClient.scan rejects the bytes cursor the standalone path uses, so every cluster scan, iter_keys and delete_pattern raised. Drive glide's cursor object internally and report one finished scan, matching how the Rust adapter reports cluster scans. Also maps the protocol's type name onto glide's ObjectType, which SCAN reads .value off.
TTL rounds to the nearest second, so a round-trip slower than 500ms reports one less and the bare pytest.approx comparison (rel=1e-6) fails.
The waiter released as soon as it was admitted, so a poll landing between holder.release() and the assert freed the slot and the jumper was admitted legitimately. Reproduced by widening that window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.