Implement ops::Index with PackageId for Resolve graph
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cycling CI |
While iterating through dependency packages, I find myself needing to look up dependency nodes recursively through the graph, in the same way that I need `Package` information for its `PackageId` via the already-existing `ops::Index` implementation on `Metadata`. This is simpler if the indexing operation is also available on a `Resolve`d graph.
MarijnS95
force-pushed
the
resolve-index-by-package-id
branch
from
2f059b4
to
e4b1243
Compare
|
@oli-obk looks like the CI run needs to be approved again. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While iterating through dependency packages, I find myself needing to look up dependency nodes recursively through the graph, in the same way that I need
Packageinformation for itsPackageIdvia the already-existingops::Indeximplementation onMetadata. This is simpler if the indexing operation is also available on aResolved graph.