feat: Enhance SDK Client to support Client ID and Secret Authorization #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredperreault-okta Can you have a look at this PR? |
bretterer
previously approved these changes
Nov 14, 2024
|
@bretterer I cleaned up the commits so they would all be verified as per you repo merge rules. Can you re-approve the PR since your initial review was dropped after I cleaned up the commits? |
bretterer
approved these changes
Dec 2, 2024
willpots
approved these changes
Dec 4, 2024
|
@bretterer thanks for the review here- for some reason, @Astro2024 and I can't merge this PR. Anything else we need to do? |
|
@jaredperreault-okta are there any other steps we need to take to get this PR Merged? |
|
Hey, any updates on this? We could really use this. Thanks! |
|
@bretterer @jefftaylor-okta @jaredperreault-okta Is there a timeline for when this PR can be merged or is there currently a moratorium on PR merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there are two ways to initialize the Okta client within the okta-sdk. The first is using an api token and the second is using a public private key pair.
Issue Number: N/A
What is the new behavior?
This PR allows someone using the okta-sdk to initialize the Okta client using client id and client secret in addition to the previous two methods mentioned.
Does this PR introduce a breaking change?
Other information
Reviewers
@jefftaylor-okta