style: wrap long trainer log lines and lift callback test import#49
Merged
Conversation
Three E501 violations in trainer.py (logger.info at line 118, __init__ signature at line 232, logger.warning reason= string at line 335) wrap to fit the project's 100-char line limit. One E402 in test_callbacks.py moves the detect_loss_spike import to the top-level block where it belongs. These four ruff errors have been gating every PR's test job since the loss-spike detection landed in #24, including the pending Dependabot idna bump (#48).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/forge/training/trainer.py(logger.info at line 118,__init__signature at line 232, logger.warningreason=string at line 335) by wrapping to the project's 100-char limittests/test_callbacks.pyby movingfrom forge.training.trainer import detect_loss_spiketo the top-level import blocktestjob since loss-spike detection landed in fix: prevent NaN gradient crash on pre-Ampere GPUs #24, including pending Dependabot idna bump (chore(deps): bump idna from 3.11 to 3.15 #48); no behavioural change