Repository navigation
Fix Go 1.27.2 and JSONv2 compatibility - #1774
Merged
Merged
Conversation
Contributor
Author
|
@ernado, sorry to be a bother, but could you help getting this (or an alternate solution to the same problem) merged? |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ogen is currently not compatible with the latest go version (at the time of writing this is go 1.27.2). While the type alias issue could be resolved by setting
GOEXPERIMENT=nojsonv2, the tools version mismatch cannot be bypassed like that. @ernado, could you please review?There are multiple issues:
JSONv2 alias for jsontext.RawMessage
tools v5 format
go vet error
Changes
x/toolsto v0.50.0 for export-data format 5 support; minimum Go version becomes 1.26.RawMessageregression tests.Related PRs
encoding/json.RawMessage = jsontext.Value, that combines package namejsontextwith type nameRawMessage, producing an incorrect qualifier. This keeps the alias'stypes.TypeName, preservingjson.RawMessagewhile inspecting its type for encoding support.x/toolsonly to v0.49.0, which lacks the format-5 support required for Go 1.27.2.