Repository navigation
fix(gen): encode const URI/string formats with e.Str - #1752
Merged
ernado merged 1 commit intoNov 13, 2026
Merged
Conversation
Const string fields with typed JSON encoders (URI, UUID, date, …) were emitted as json.EncodeURI(e, "…"), which expects url.URL and does not compile. Emit e.Str for const JSON strings instead. Fixes ogen-go#1751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Const object properties with
type: stringand a typed JSON encoder (format: uri, UUID, date, and similar) were generated as:json.EncodeURI(and the other typed encoders) takeurl.URL/ typed Go values, not a string constant, so the generated package does not compile.For const JSON strings whose encoder has no
jxprimitive (Fnempty,Type == "String"), emite.Str(...)instead. Required and optional const URI fields are both covered.Test plan
go test ./gen/ -run TestGenerateSchemaConstURICompiles -count=1(RED on main template, GREEN after fix)Fixes #1751