Repository navigation
fix: recordSpanError 改 errors.Is + OTLP/HTTP 无 scheme 带路径报错 + metrics 装配单源(#110-#112) - #114
Closed
zy84338719 wants to merge 2 commits into
Closed
zy84338719 wants to merge 2 commits into
zy84338719 wants to merge 2 commits into
Conversation
…cs 装配尾段单源(#110-#112) - recordSpanError 哨兵判定 switch == → errors.Is(#111):业务「未命中」是 最高频的被包装哨兵(fmt.Errorf(%w)/errors.Join 包装后 == 全部落空), 未命中查询被 RecordError + SetStatus(Error),APM 全量报红,与注释声明的 「业务语义性错误不算失败」相反 - parseOTLPHTTPEndpoint 无 scheme 分支对带路径写法显式报错(#112): "collector:4318/api/otel" 此前整串当 host:port,basePath 恒空、导出 404 循环;对齐 validateGRPCEndpoint「不合规输入报错,不静默断供」纪律, 错误不回显端点原值(凭据纪律);补表驱动用例钉住 - assembleMeterProvider 单源化(#110):gRPC 与 HTTP 两条导出分支的 PeriodicReader+MeterProvider+runtime.Start+失败回滚尾段收敛为一个函数, 「必须显式指定 provider」关键注释只留一份 验证: gofmt/build/vet/全仓测试(含新用例)全绿
Contributor
Author
|
让道收尾:本 PR 的三单(#110/#111/#112)已由 2026-11-12 的 #116 修复并随 v0.4.1 发布(CHANGELOG 版本节逐条绑定、回执已逐单关单)。
本 PR 与 #116 同源同方案(errors.Is / 无 scheme 报错 / 装配单源),继续挂 open 只会 CI 空转 + 冲突堆积,按「并行会话让道」纪律关闭;如对实现有异议请重开单讨论。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 3 条(本仓 backlog 全量清零):
P2
P2(重构)
验证
gofmt / go build / go vet / go test ./... 全绿(含新增 #112 用例)