Remove GovernanceDomainDescriptions #8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+86
to
+102
| String validValueGUID = this.archiveHelper.addValidValue(null, | ||
| governanceDomainSetGUID, | ||
| governanceDomainSetGUID, | ||
| OpenMetadataType.VALID_VALUE_SET.typeName, | ||
| OpenMetadataType.VALID_VALUE_DEFINITION.typeName, | ||
| OpenMetadataType.VALID_VALUE_SET.typeName, | ||
| domainDefinition.getQualifiedName(), | ||
| domainDefinition.getDisplayName(), | ||
| domainDefinition.getDescription(), | ||
| domainDefinition.getCategory(), | ||
| OpenMetadataValidValues.VALID_METADATA_VALUES_USAGE, | ||
| DataType.INT.getName(), | ||
| OpenMetadataValidValues.OPEN_METADATA_ECOSYSTEM_SCOPE, | ||
| Integer.toString(domainDefinition.getDomainIdentifier()), | ||
| false, | ||
| false, | ||
| null); |
Check notice
Code scanning / CodeQL
Unread local variable Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the GovernanceDomainSet and GovernanceDomainDescription types and removed support for them from the GovernanceProgram OMAS. The reason for this change is to use the standard valid metadata values for to governance program as is ued for all other metadata. It removes unnecessary REST API operations and reduces the functions that users need to know.
Related Issue(s)
The template for an Apache Kafka Topic is no longer using the secrets store. This is because the connector does not support the secrets store. At some poit the connector needs to be updated to support the secrets store to retrieve the certificates needed to contact the kafka broker. The template can be updated at that time.
Testing
FVT
Release Notes & Documentation
The documentation has been updated to reflect this change.
Additional notes