Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framework clients to OMASs #7967

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Add framework clients to OMASs #7967

merged 1 commit into from
Dec 30, 2023

Conversation

odttlnt
Copy link
Contributor

@odttlnt odttlnt commented Dec 12, 2023

Each Open Metadata Access Service (OMAS) Client should have two framework clients plus one or more specialized clients. This enhancement is to ensure that the two framework clients are added to all OMASs.

Description

As part of the changes client modules named ConnectedAssetClient and OpenMetadataStoreClient were added to the OMAS under access-services

Related Issue(s)

#7857

Testing

A clean build with all FVTS was done on the project

Release Notes & Documentation

NA

Additional notes

NA

Copy link
Contributor

@mandy-chessell mandy-chessell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new clients, where I can see them look good 👍

However, there are 993 files changed in this PR. Most of these are just reorganizing the imports of files unconnected with the change. I think there must be a setting wrong in your IDE that is causing this. You need to work out what that is and resubmit with a PR that only includes the files that you changed (deliberately :) .

@odttlnt odttlnt force-pushed the issue7857 branch 2 times, most recently from 987d900 to f2a2a72 Compare December 25, 2023 03:26
@odttlnt
Copy link
Contributor Author

odttlnt commented Dec 25, 2023

The new clients, where I can see them look good 👍

However, there are 993 files changed in this PR. Most of these are just reorganizing the imports of files unconnected with the change. I think there must be a setting wrong in your IDE that is causing this. You need to work out what that is and resubmit with a PR that only includes the files that you changed (deliberately :) .

Hello @mandy-chessell ,
Thanks for pointing that out. I have made the changes and asked for the review again. Please have a look when you can.
Happy Holidays and a new year !!!

Copy link
Contributor

@mandy-chessell mandy-chessell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very nice job - thank you :)

@mandy-chessell mandy-chessell merged commit 8e84a9b into odpi:main Dec 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants