Skip to content

Conversation

xmo-odoo
Copy link
Contributor

odoo/odoo#195664 removed explicit namespace support, as a result the __init__ files break the ability to hook upgrade in via PYTHONPATH, as under PEP420 no namespace entry may have a__init__ files within the shared namespace path.

@robodoo
Copy link
Contributor

robodoo commented Mar 19, 2025

Pull request status dashboard

@xmo-odoo xmo-odoo force-pushed the master-pep420-compatibility-xmo branch 2 times, most recently from d65b41c to 6463260 Compare March 19, 2025 10:33
@rven
Copy link

rven commented Sep 24, 2025

What is the status of this PR?

Odoo doesn't start anymore when the package is installed.

initialize_sys_path
    odoo.upgrade.__path__._path_finder = lambda *a: None  # prevent path invalidation
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'list' object has no attribute '_path_finder'

odoo/odoo#195664 removed explicit namespace support, as a result the
`__init__` files break the ability to hook upgrade in via
`PYTHONPATH`, as under PEP420 no namespace entry may have a`__init__`
files within the shared namespace path.
@aj-fuentes aj-fuentes force-pushed the master-pep420-compatibility-xmo branch from 6463260 to a33e76e Compare September 24, 2025 19:07
@aj-fuentes
Copy link
Contributor

Rebased to let the CI test it.

@aj-fuentes
Copy link
Contributor

upgradeci retry with base account in all versions

@aj-fuentes
Copy link
Contributor

@KangOl I confirm it works while upgrading a DB from 7.0 up to 19.0 both locally and in the platform. If the CI is all good this looks good to go.

@aj-fuentes aj-fuentes requested a review from KangOl September 24, 2025 19:10
Copy link
Contributor

@KangOl KangOl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants