chapter1-No.6 #976
Open
chapter1-No.6 #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo/tutorials:18.0-oBoarding-yoahm, it needs to be retargeted before it can be merged. |
|
Hey @usseif97 you're targeting your own branch here. Edit the PR to target 18.0 |
cgun-odoo
reviewed
Sep 26, 2025
awesome_dashboard/static/src/dashboard/configuration_dialog/configuration_dialog.js
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| setup() { | ||
| this.checkBoxItems = useState(this.props.items.map((item) => { // Add 'enabled' field to Item -> return Array of Objects |
There was a problem hiding this comment.
Suggested change
| this.checkBoxItems = useState(this.props.items.map((item) => { // Add 'enabled' field to Item -> return Array of Objects | |
| this.checkBoxItems = useState(this.props.items.map((item) => { |
what's that comment for 😆
There was a problem hiding this comment.
it's just a note for me, that item object have a new field now
awesome_dashboard/static/src/dashboard/configuration_dialog/configuration_dialog.js
Outdated
Show resolved
Hide resolved
awesome_dashboard/static/src/dashboard/number_card/number_card.js
Outdated
Show resolved
Hide resolved
awesome_dashboard/static/src/dashboard/number_card/number_card.js
Outdated
Show resolved
Hide resolved
|
|
||
| addTodo(event) { | ||
| if(event.key === "Enter" && event.target.value.trim() !== ""){ | ||
| const newId = this.todos.length ? Math.max(...this.todos.map(t => t.id)) +1 : 1; |
There was a problem hiding this comment.
You can keep a state variable called nextId or currentId which keeps track of this value I think it would look better
Comment on lines
+1
to
+21
| /** | ||
| * useAutofocus - helper to focus an input element | ||
| * @param {Component} component - the component instance | ||
| * @param {string} refName - the t-ref name of the input element | ||
| */ | ||
| export function useAutofocus(component, refName) { | ||
| // Store original mounted method | ||
| const originalMounted = component.mounted; | ||
|
|
||
| component.mounted = function () { | ||
| // Call original mounted() if it exists | ||
| if (originalMounted) { | ||
| originalMounted.call(this); | ||
| } | ||
|
|
||
| // Focus the element | ||
| if (this.refs && this.refs[refName]) { | ||
| this.refs[refName].focus(); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
This looks a bit ai generated to me huh 🤔
There was a problem hiding this comment.
Yes, but it didn’t work, so I moved on and continued with the next step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.