Skip to content

18.0-training-nosir #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

18.0-training-nosir #973

wants to merge 1 commit into from

Conversation

nsirjacobs
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Sep 23, 2025

Pull request status dashboard

@cgun-odoo cgun-odoo self-requested a review September 26, 2025 07:35
cgun-odoo
cgun-odoo reviewed Sep 26, 2025
View reviewed changes
cgun-odoo
cgun-odoo reviewed Sep 26, 2025
View reviewed changes
Copy link

@cgun-odoo cgun-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@cgun-odoo
Copy link

Nooooo you squashed everything but you could have 2 commits for the 2 chapters (awesome_owl - awesome_dashboard)
You can update the commit message to indicate both of them are included in that commit

@cgun-odoo
Copy link

Also on the commit message use the module name in snake_case awesome_dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgun-odoo cgun-odoo cgun-odoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsirjacobs @robodoo @cgun-odoo