-
Notifications
You must be signed in to change notification settings - Fork 2k
Real Estate Module #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Real Estate Module #742
Conversation
Will Fix the ci/style error in the next commit (I think i meant after 12 commits) |
265f333
to
0703ba7
Compare
0703ba7
to
ce74e7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abyo-odoo
Here is another round of comments. Don't hesitate to ask if you have questions about these (or anything else 🙂 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello :) -- good work !
I left some comments on your code.
Also you haven't made corrections for the comments from the previous reviews by Valentin -- could you look at it please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nitpicks on the js ^^
@vava-odoo @naja628 Thank you for your reviews and efforts during the technical onboarding! |
New pull request with a different branch name following the correct convention.