Skip to content

Real Estate Module #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 27 commits into
base: 18.0
Choose a base branch
from
Draft

Conversation

abyo-odoo
Copy link

@abyo-odoo abyo-odoo commented Apr 24, 2025

New pull request with a different branch name following the correct convention.

@robodoo
Copy link

robodoo commented Apr 24, 2025

Pull request status dashboard

@abyo-odoo
Copy link
Author

abyo-odoo commented Apr 24, 2025

Will Fix the ci/style error in the next commit (I think i meant after 12 commits)

@abyo-odoo abyo-odoo force-pushed the 18.0-TechnicalTraining-abyo branch from 265f333 to 0703ba7 Compare April 25, 2025 10:05
@abyo-odoo abyo-odoo force-pushed the 18.0-TechnicalTraining-abyo branch from 0703ba7 to ce74e7b Compare April 25, 2025 10:39
Copy link

@vava-odoo vava-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abyo-odoo
Here is another round of comments. Don't hesitate to ask if you have questions about these (or anything else 🙂 )

@abyo-odoo
Copy link
Author

@vava-odoo

Copy link

@naja628 naja628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello :) -- good work !

I left some comments on your code.

Also you haven't made corrections for the comments from the previous reviews by Valentin -- could you look at it please?

Copy link

@naja628 naja628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nitpicks on the js ^^

@abyo-odoo
Copy link
Author

@vava-odoo @naja628 Thank you for your reviews and efforts during the technical onboarding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants