Enhance Appointment Filters: Type, Appointment Schedule, and Payment Step #692

kuay-odoo · 2025-04-03T05:36:21Z

This PR introduces enhanced filtering options for appointments, improving the user experience when searching for specific appointments. The following filters have been added:

Appointment Type Filter: Allows users to filter appointments based on whether they are online or offline.

Schedule Filter: Enables filtering based on scheduling criteria, allowing users to choose between appointments scheduled by users or resources.

Payment Step Filter: Adds a filter to distinguish between appointments that require a payment step and those that do not.

These filters enhance the appointment browsing experience, making it easier for users to find relevant appointments based on their preferences. The implementation follows the existing filtering structure used in similar features, such as event filtering.

robodoo · 2025-04-03T05:36:24Z

… payment Added new filters to improve appointment scheduling and management: Type filter- Allows users to filter appointments based on whether they are online or offline. Schedule filter- Enables filtering appointments based on users or resources, similar to the event module. Payment step filter-Adds the ability to filter appointments based on whether they include a payment step. These enhancements improve usability and provide better appointment organization.

This commit introduces a complete feature for managing warranty products within the Sales application: - Added a Is Warranty Available boolean field on product templates to indicate warranty eligibility. - Moved warranty configuration under the 'Configuration' menu in the Sales app for better accessibility and UX alignment. - Introduced a wizard for adding warranty products to sale orders, dynamically computing prices and descriptions based on selected lines. - Implemented automatic deletion of warranty wizard lines when the product is removed from the wizard to maintain data integrity. This feature improves the workflow for managing extended warranties, providing a seamless integration in Sales for both users and system operations.

Introduce a supplier-facing portal feature to streamline invoice submission. Features: - Allow authenticated users in the `Supplier User` group to upload invoices via website form. - Security: - Access restricted to users in the `Supplier User` group. - CSRF token protection for form submissions. - Company selection: - Lists companies linked to the user. - Allows user to select the target company for invoice submission. - File handling: - Uploaded files are stored as attachments. - Vendor bill is associated with a purchase journal from the selected company. - Confirmation message shown upon successful submission. - Adds a new security group: `Supplier User` and website menu item Upload Invoice, visible only to users in the `Supplier User` group. Benefits: - Enables suppliers to directly submit invoice files from the portal. - Improves workflow efficiency and reduces manual data entry for internal teams.

…Manufacture - Introduced 'modular.type' model to define modular categories. - Linked modular types to product templates via many2many field. - Added modular_type_id in BOM lines with dynamic filtering per product. - Added security access rules for new models and wizards. - Extended views for BOM, manufacturing orders, sale orders, and product templates. - Created 'sale.order.line.modular.type' model to hold modular values for sale order lines. - Displayed modular types via wizard in sale order lines. - Updated stock moves to inherit modular type from BOM line. - Adjusted MRP component quantity using modular value during order confirmation.

- Added `is_approval` boolean field to `sale.order` model. - Introduced computed field `is_approval_read` to control read-only access. - Only Sales Managers (based on group) can edit the approval checkbox. - Overrode `action_confirm` to block confirmation if not approved. - XML view updated to display approval checkbox next to payment terms. - Enforces a lightweight approval mechanism before confirming sales orders.

nihp-odoo

Hello @kuay-odoo
Some changes and suggestion on your website_appointment_filter task.
Thanks!

nihp-odoo · 2025-04-15T11:30:02Z

website_appointment_filter/__manifest__.py

+        "views/website_appointment_filter.xml",
+    ],
+    "auto-install": True,
+    "application": False,


Its False by default, if we need it as an application then we should define it as True.

nihp-odoo · 2025-04-15T11:35:20Z

website_appointment_filter/controllers/website_appointment_filter.py

+from odoo import http
+from odoo.addons.website_appointment.controllers.appointment import WebsiteAppointment  # type: ignore
+from odoo.http import request
+


Suggested change

nihp-odoo · 2025-04-15T11:35:27Z

website_appointment_filter/controllers/website_appointment_filter.py

+from odoo.http import request
+
+class WebsiteAppointmentFilter(WebsiteAppointment):
+


Suggested change

nihp-odoo · 2025-04-15T12:21:38Z

website_appointment_filter/controllers/website_appointment_filter.py

+        available_appointments = request.env["appointment.type"].sudo().search(total_domain)
+        appointment_data = self._prepare_appointments_cards_data(page, available_appointments, **params)
+
+        return request.render("website_appointment.appointments_cards_layout", appointment_data)


Only using card design? What about when user opts for list design?
Instead of directly changing this function, check the code flow and edit related functions.

nihp-odoo · 2025-04-15T12:34:34Z

website_appointment_filter/controllers/website_appointment_filter.py

+        return request.render("website_appointment.appointments_cards_layout", appointment_data)
+
+    def _build_filter_domain(self, params):
+


Suggested change

adsh-odoo

Hello @kuay-odoo
Some suggestions/questions on the add product warranty task.
Also not able to install module on runbot need to update some sequence of file in the manifest.
Cheers!!!

adsh-odoo · 2025-04-17T05:46:58Z

add_product_warranty/models/sale_order_unlink.py

Need to update the file name.

adsh-odoo · 2025-04-17T05:56:18Z

add_product_warranty/views/sale_order_button.xml

Same here, need to update the file name, check other occurrences also.

adsh-odoo · 2025-04-17T06:08:44Z

add_product_warranty/models/sale_order_unlink.py

+    def unlink(self):
+        for line in self:
+            linked_warranty_lines = self.search(
+                [("linked_sale_order_line_id", "=", line.id)]
+            )
+
+            linked_warranty_lines.unlink()
+
+        return super(salesOrderLine, self).unlink()


Rather than overriding this unlink function, can't we use the ondelete cascade property?
Or for the instant effect, we can also use onchange.

adsh-odoo · 2025-04-17T06:27:21Z

add_product_warranty/views/product_template.xml

+            <xpath expr="//page[@name='sales']/group[@name='sale']" position="inside">
+                <group string="Product Warranty" name="product_warranty">
+                    <field name="is_warranty_available" />
+                </group>
+            </xpath>


Can we target with a simpler XPath?

adsh-odoo · 2025-04-17T06:57:54Z

add_product_warranty/models/product_warranty.py

+    _name = "product.warranty"
+    _description = "Product Warranty"
+
+    name = fields.Char(string="Name", required=True)


In spec it is mentioned that we have to make a manyone with a product, so a warranty will also be a product.

adsh-odoo · 2025-04-17T06:59:13Z

add_product_warranty/wizard/add_warranty_wizard.py

+    _description = "Wizard to add Warranty for product"
+
+    sale_order_id = fields.Many2one("sale.order", string="Quotation", required=True)
+    line_ids = fields.One2many("warranty.wizard.line", "wizard_id", string=" ")


Why empty string attribute here?

adsh-odoo · 2025-04-17T07:09:54Z

add_product_warranty/wizard/add_warranty_wizard.py

+    _name = "warranty.wizard"
+    _description = "Wizard to add Warranty for product"
+
+    sale_order_id = fields.Many2one("sale.order", string="Quotation", required=True)


I don't think there is a need for this field.

adsh-odoo · 2025-04-17T07:10:30Z

add_product_warranty/wizard/add_warranty_wizard.py

+        if total_price > 0:
+            self.env["sale.order.line"].create(
+                {
+                    "order_id": self.sale_order_id.id,


You can get the order ID from the context instead of making a separate field.

adsh-odoo · 2025-04-17T07:15:30Z

add_product_warranty/wizard/warranty_wizard_line.py

+    sale_order_line_id = fields.Many2one("sale.order.line", string="Sale order Line")
+    warranty_id = fields.Many2one("product.warranty", string="Warranty")
+
+    validity_year = fields.Integer(


Instead of creating the field we can use directly warranty_id.validity_year.

adsh-odoo · 2025-04-17T08:03:55Z

add_product_warranty/wizard/warranty_wizard_line.py

+    _description = "warranty Line to Select Warranty"
+
+    wizard_id = fields.Many2one("warranty.wizard", string="Wizard")
+    product_id = fields.Many2one("product.product", string="Product")


Why is this field required?

nihp-odoo

Hello @kuay-odoo
Some changes on your zero_stock_blockage task.
Thanks!

nihp-odoo · 2025-04-17T08:58:42Z

zero_stock_blockage/__manifest__.py

+       "views/sale_order.xml",
+    ],
+    "auto-install": True,
+    "application": False,


Its False by default, so no need to mention it.

nihp-odoo · 2025-04-17T09:00:23Z

zero_stock_blockage/models/__init__.py

@@ -0,0 +1 @@
+from . import sale_order


Missing line here..

nihp-odoo · 2025-04-17T09:02:18Z

zero_stock_blockage/models/sale_order.py

+class SaleOrder(models.Model):
+    _inherit = "sale.order"
+
+    is_approval = fields.Boolean(string="Approval")


Give better to a field (Also, here field name is mentioned in specs)

nihp-odoo · 2025-04-17T09:05:09Z

zero_stock_blockage/models/sale_order.py

+    _inherit = "sale.order"
+
+    is_approval = fields.Boolean(string="Approval")
+    is_approval_read = fields.Boolean(compute="_compute_to_set_approval")


Suggested change

is_approval_read = fields.Boolean(compute="_compute_to_set_approval")

is_approval_read = fields.Boolean(compute="_compute_is_approval_read")

nihp-odoo · 2025-04-17T09:09:07Z

zero_stock_blockage/views/sale_order.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="sale_approval_checkbox" model="ir.ui.view">


Give ID name according to the coding guidelines.
https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

nihp-odoo · 2025-04-17T09:23:45Z

zero_stock_blockage/models/sale_order.py

+        user = self.env.user
+        is_user_manager = user.has_group("sales_team.group_sale_manager")


Suggested change

user = self.env.user

is_user_manager = user.has_group("sales_team.group_sale_manager")

is_user_manager = self.env.user.has_group("sales_team.group_sale_manager")

kuay-odoo added 2 commits April 3, 2025 11:15

kuay-odoo force-pushed the 18.0-practice-task-kuay branch from 4312c25 to 630e34e Compare April 3, 2025 05:46

kuay-odoo added 3 commits April 15, 2025 10:30

kuay-odoo force-pushed the 18.0-practice-task-kuay branch from 4bff046 to 03fea4d Compare April 15, 2025 05:18

nihp-odoo reviewed Apr 15, 2025

View reviewed changes

adsh-odoo reviewed Apr 17, 2025

View reviewed changes

nihp-odoo reviewed Apr 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Appointment Filters: Type, Appointment Schedule, and Payment Step #692

Enhance Appointment Filters: Type, Appointment Schedule, and Payment Step #692

kuay-odoo commented Apr 3, 2025

robodoo commented Apr 3, 2025

nihp-odoo left a comment

nihp-odoo Apr 15, 2025

nihp-odoo Apr 15, 2025

nihp-odoo Apr 15, 2025

nihp-odoo Apr 15, 2025

nihp-odoo Apr 15, 2025

adsh-odoo left a comment

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

adsh-odoo Apr 17, 2025

nihp-odoo left a comment

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

		from odoo.http import request

		class WebsiteAppointmentFilter(WebsiteAppointment):

		return request.render("website_appointment.appointments_cards_layout", appointment_data)

		def _build_filter_domain(self, params):

	is_approval_read = fields.Boolean(compute="_compute_to_set_approval")
	is_approval_read = fields.Boolean(compute="_compute_is_approval_read")

		user = self.env.user
		is_user_manager = user.has_group("sales_team.group_sale_manager")

	user = self.env.user
	is_user_manager = user.has_group("sales_team.group_sale_manager")
	is_user_manager = self.env.user.has_group("sales_team.group_sale_manager")

Enhance Appointment Filters: Type, Appointment Schedule, and Payment Step #692

Are you sure you want to change the base?

Enhance Appointment Filters: Type, Appointment Schedule, and Payment Step #692

Conversation

kuay-odoo commented Apr 3, 2025

robodoo commented Apr 3, 2025

nihp-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adsh-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nihp-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment