18.0 practice task agir #688

agir-odoo · 2025-04-02T13:22:10Z

[ADD] dev_zero_stock_blockage: implemented zero stock approval task
Ensure that Sales Orders cannot be confirmed without Zero Stock Approval,
restricting Sales Users from modifying the field while allowing only
Sales Administrators to approve orders.

--> Inherited Model

Inherited the main model sale order.
Added a new boolean field zero stock approval in the sale order model.
Overridden fields get() to make the field read-only for Sales Users
(sales person)
Made action confirm() to restrict order confirmation unless
zero stock approval is checked.
Implemented sale order views xml to display zero stock approval
after payment term id.

Access Rights

Sales Administrator - Can edit the field.
Sales User : Read-only access.

Ensures better control over order confirmation based on stock approval.

robodoo · 2025-04-02T13:22:13Z

Ensure that Sales Orders cannot be confirmed without Zero Stock Approval, restricting Sales Users from modifying the field while allowing only Sales Administrators to approve orders. --> Inherited Model - Inherited the main model sale order. - Added a new boolean field zero stock approval in the sale order model. - Overridden fields get() to make the field read-only for Sales Users (sales person) - Made action confirm() to restrict order confirmation unless zero stock approval is checked. - Implemented sale order views xml to display zero stock approval after payment term id. Access Rights - Sales Administrator - Can edit the field. - Sales User : Read-only access. - Created a boolean field 'zero_stock_approval' to allow admins to approve orders with low stock - Only Sales Manager can edit this field; others see it as readonly - If any product has demand > available stock and the user is not a manager, they must get admin approval - Blocked order confirmation if quantity is less than available and no approval is given - Skipped stock check for service and combo products (only checked consu {goods} type) - Added a warning message popup when admin gives approval for a product with low stock Ensures better control over order confirmation based on stock approval.

…n POS UI - Created a new module salesperson button in pos - Added salesperson id field in posorder model to track salesperson - Created a new button Select Salesperson in POS frontend - Implemented the button in controlbutton xml - Developed select salesperson button js as an OWL component - Patched ControlButtons to include the Salesperson button in POS - Registered assets properly in manifest py for POS UI - Debugged and tested visibility of the button in POS UI

…sub-product - Introduced 'Is Kit' field on product templates to define kit-type products - Added Many2many field to select sub-products for a kit - Added smart button 'Configure Kit' on sale order line, visible only for kit products - Created a wizard to select sub-product quantity and price per main product - Sub-products are auto-added as separate sale order lines under the main kit line - Sub-product lines are read-only & priced at 0 (cost included in main product) - Sub-products support storable/consumable product types for stock tracking - Main product's unit price remains unchanged; subtotal includes sub-product costs - Sub-product lines are auto-deleted if the main kit line is removed - Added 'Print in Report' checkbox on Sale Order to control sub-product visibility - Applied conditional display of sub-products in: - Sale Order PDF - Portal Order Preview - Invoice PDF (QWeb-safe logic using t-set variables)

- Added a new field in product form to set a second UoM - Backend constraint to prevent primary and secondary UoM being the same - Loaded second UoM info into POS - Added custom Add Quantity button in POS control panel(before customer button) - Clicking the button opens a popup to enter quantity in second UoM - POS converts the quantity based on UoM ratio - Added validations in popup: - Show error if quantity is zero or negative or empty input - Optimized validation with translatable error message - UI improvements with conditional visibility and consistent UX

nihp-odoo

Hello @agir-odoo
Some suggestion and changes on your new_product_type_kit.

After adding kit once, if I am again click on 'configure kit' and remove one of the kit lines then price is updated but the it is still present in sale order line.. Check it out!

Thanks!

nihp-odoo · 2025-04-16T05:13:21Z

new_product_type_kit/__manifest__.py

@@ -0,0 +1,22 @@
+{
+    'name': 'Dev Zero Stock Blockage',


nihp-odoo · 2025-04-16T05:13:56Z

new_product_type_kit/__manifest__.py

+    'description': """
+        Add kit-type products with configurable sub-products and conditional report visibility
+    """,


Check indentation in codebase!

nihp-odoo · 2025-04-16T05:16:36Z

new_product_type_kit/__manifest__.py

+        Add kit-type products with configurable sub-products and conditional report visibility
+    """,
+    'author': 'Raghav Agiwal',
+    'depends': ['sale_management', 'stock', 'product'],


Do we need stock here? Also only sale_management will work fine.

nihp-odoo · 2025-04-16T05:17:30Z

new_product_type_kit/__manifest__.py

+        'report/report_invoice_templates.xml',
+    ],
+    'installable': True,
+    'application': True,


We don't need this module as an application!

nihp-odoo · 2025-04-16T05:46:03Z

new_product_type_kit/models/sale_order.py

+
+    print_in_report = fields.Boolean(
+        string="Print in report?",
+        default=False


It'll be False by default. This is used if we are going other way.

nihp-odoo · 2025-04-16T05:56:13Z

new_product_type_kit/models/sale_order_line.py

+            }
+        }
+
+    def unlink(self):


This function is letting user delete sub products. Check functional flow.

nihp-odoo · 2025-04-16T06:23:53Z

new_product_type_kit/views/kit_wizard_views.xml

It should be inside wizard folder.

nihp-odoo · 2025-04-16T06:28:35Z

new_product_type_kit/views/kit_wizard_views.xml

+                    <field name="product_id" readonly="1"/>
+                </group>
+
+                <group string="Sub Products">


Use <sheet> instead of <group> here.

nihp-odoo · 2025-04-16T06:41:40Z

new_product_type_kit/wizard/kit_wizard.py

+    _name = 'kit.wizard'
+    _description = 'Kit Wizard'
+
+    product_id = fields.Many2one('product.product', string='Product', required=True)


Are we using this field?

nihp-odoo · 2025-04-16T06:48:50Z

new_product_type_kit/wizard/kit_wizard.py

+        order_id = self.env.context.get("active_id")
+        sale_order_line_id = self.env.context.get("default_sale_order_line_id")
+        order = self.env["sale.order"].browse(order_id)
+        parent_line = order.order_line.filtered(lambda l: l.id == sale_order_line_id)


We should avoid such variable names.

nihp-odoo

Hello @agir-odoo
Some comments on your salesperson_button_in_pos task.
Thanks!

nihp-odoo · 2025-04-16T10:03:22Z

salesperson_button_in_pos/__manifest__.py

+    'description': """
+        Adding salesperson button in pos
+    """,


Suggested change

'description': """

Adding salesperson button in pos

""",

'description': """

Adding salesperson button in pos

""",

Check codebase for more examples.

nihp-odoo · 2025-04-16T10:04:43Z

salesperson_button_in_pos/__manifest__.py

+    ],
+    'assets': {
+        'point_of_sale._assets_pos': [
+            'salesperson_button_in_pos/static/src/app/**/*',


We can directly work in static/src no need to create separate folder inside.

nihp-odoo · 2025-04-16T10:05:23Z

salesperson_button_in_pos/__manifest__.py

+        ],
+    },
+    'installable': True,
+    'application': True,


No need to make this an application.

nihp-odoo · 2025-04-16T10:07:23Z

salesperson_button_in_pos/models/__init__.py

@@ -0,0 +1,3 @@
+from . import pos_order
+from . import pos_session
+from . import hr_employee


Why are we making this hr_employee file?

nihp-odoo · 2025-04-16T10:44:13Z

salesperson_button_in_pos/static/src/app/salesperson_list/salesperson_list.js

+
+

Suggested change

nihp-odoo · 2025-04-16T12:41:46Z

salesperson_button_in_pos/static/src/app/salesperson_list/salesperson_list.js

+            selectedSalesPerson: null
+        });
+        useHotkey("enter", () => this.onEnter());
+        this.loadSalespeople();


Why not call this.getSalespersons() directly from here.

nihp-odoo · 2025-04-16T13:07:52Z

salesperson_button_in_pos/views/pos_order_view.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="view_pos_order_form" model="ir.ui.view">


Checkout coding guidelines for ID naming.
https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

nihp-odoo · 2025-04-16T13:19:31Z

salesperson_button_in_pos/static/src/app/salesperson_list/salesperson_list.xml

+                                <td class="salesperson-line-email">
+                                </td>
+                                <td>
+                                    <t t-if="this.props.currentSelectedSalesperson?.id === salesperson?.id">


It works on the whole salesperson! If I again click on the selected salesperson it gets deselected. We should allow this when we only click in the 'cross'

nihp-odoo · 2025-04-16T13:21:48Z

salesperson_button_in_pos/static/src/app/salesperson_list/salesperson_list.xml

+            <div t-if="state.query" class="search-more-button d-flex justify-content-center my-2">
+                <button class="btn btn-lg btn-primary" t-on-click="onEnter">Search more</button>
+            </div>


Why are we adding this button, it just triggers the notification!

nihp-odoo · 2025-04-16T13:38:40Z

...creens/product_screen/control_buttons/select_salesperson_button/select_salesperson_button.js

+        this.state = useState({ selectedSalesPerson: null });
+    }
+
+    async selectSalesperson() {


Why are we doing same thing twice? Here and in salesperson_list?

nihp-odoo

Hello @agir-odoo
Some comments on your dev_zero_stock_bloackage task.
Thanks...

nihp-odoo · 2025-04-17T05:56:40Z

dev_zero_stock_blockage/__manifest__.py

+    'description': """
+        This module stops Sales Orders from being confirmed if any product is out of stock, unless a Sales Manager gives approval.
+        Sales users can see the Zero Stock Approval field but cannot edit it.
+        It only checks stock for physical products, not services or combos.
+    """,


Indentation is not proper.. checkout codebase.
Also, do we need stock in depends?

nihp-odoo · 2025-04-17T06:04:16Z

dev_zero_stock_blockage/__manifest__.py

+        'views/sale_order_views.xml',
+    ],
+    'installable': True,
+    'application': True,


No need to make it an application.

nihp-odoo · 2025-04-17T06:22:57Z

dev_zero_stock_blockage/models/sale_order.py

+                        'warning': {
+                            'title': "Heads Up!",
+                            'message': (
+                                f"Just a quick reminder..!! You are approving this order where product '{line.product_id.display_name}' "
+                                f"has demand {line.product_uom_qty} > available {line.product_id.qty_available}."
+                            )
+                        }


What if there are 2 sale_order_line where product_uom_qty is greater than qty_available? Warning will display only the first one it found.

nihp-odoo · 2025-04-17T06:56:01Z

dev_zero_stock_blockage/views/sale_order_views.xml

+            </xpath>
+        </field>
+    </record>
+


Suggested change

nihp-odoo · 2025-04-17T06:56:28Z

dev_zero_stock_blockage/views/sale_order_views.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="view_sale_order_form" model="ir.ui.view">


Name ID according to the coding guideline!

nihp-odoo · 2025-04-17T06:58:21Z

dev_zero_stock_blockage/models/sale_order.py

+                    raise UserError(
+                        f"Cannot confirm this Sale Order.\n"
+                        f"Product '{line.product_id.display_name}' has only {available_qty} in stock, "
+                        f"but {demand_qty} is requested.\n"
+                        f"Approval is required to proceed."
+                    )


Here too! same issue as warning.

nihp-odoo · 2025-04-17T06:58:36Z

dev_zero_stock_blockage/models/sale_order.py

+                # if demand_qty <= 0:
+                #         raise UserError(
+                #         f"You cannot confirm this Sale Order.\n"
+                #         f"Product '{line.product_id.display_name}' has a quantity of {demand_qty}.\n"
+                #         f"Quantity must be greater than zero."
+                # )


nihp-odoo · 2025-04-17T06:58:41Z

dev_zero_stock_blockage/models/sale_order.py

+                    raise UserError(
+                        f"Cannot confirm this Sale Order.\n"
+                        f"Product '{line.product_id.display_name}' has only {available_qty} in stock, "
+                        f"but {demand_qty} is requested.\n"
+                        f"Approval is required to proceed."
+                    )


Here too! same issue as warning.

nihp-odoo · 2025-04-17T07:10:28Z

dev_zero_stock_blockage/models/sale_order.py

+    def _onchange_zero_stock_approval(self):
+        if self.zero_stock_approval and self.env.user.has_group('sales_team.group_sale_manager'):
+            for line in self.order_line:
+                if line.product_id.type in ['consu', 'product'] and line.product_uom_qty > line.product_id.qty_available:


I think there is no product_type called product.

agir-odoo force-pushed the 18.0-practice-task-agir branch 8 times, most recently from 9643f88 to 137fcbf Compare April 9, 2025 08:18

agir-odoo force-pushed the 18.0-practice-task-agir branch from 662b14a to bcdf892 Compare April 14, 2025 06:17

agir-odoo added 3 commits April 14, 2025 12:08

agir-odoo force-pushed the 18.0-practice-task-agir branch 5 times, most recently from aaa079f to 0665818 Compare April 15, 2025 13:47

agir-odoo force-pushed the 18.0-practice-task-agir branch from 0665818 to b103d52 Compare April 15, 2025 18:45

nihp-odoo reviewed Apr 16, 2025

View reviewed changes

nihp-odoo reviewed Apr 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18.0 practice task agir #688

18.0 practice task agir #688

agir-odoo commented Apr 2, 2025 •

edited

Loading

robodoo commented Apr 2, 2025

nihp-odoo left a comment

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo left a comment

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo Apr 16, 2025

nihp-odoo left a comment

nihp-odoo Apr 17, 2025 •

edited

Loading

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

nihp-odoo Apr 17, 2025

18.0 practice task agir #688

Are you sure you want to change the base?

18.0 practice task agir #688

Conversation

agir-odoo commented Apr 2, 2025 • edited Loading

robodoo commented Apr 2, 2025

nihp-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nihp-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nihp-odoo left a comment

Choose a reason for hiding this comment

nihp-odoo Apr 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agir-odoo commented Apr 2, 2025 •

edited

Loading

nihp-odoo Apr 17, 2025 •

edited

Loading