18.0 gato tutorials #657

gato-odoo · 2025-03-20T12:01:29Z

finished exercises

robodoo · 2025-03-20T12:01:32Z

gato-odoo · 2025-03-24T07:56:45Z

Rebased to reword some commit messages,
added components for frontend tutorials chapter 1

…state properties.

A simple counter component that increases when its button is clicked task-xxxxx

A basic card component with a title and a description task-xxxxx

… items task-xxxxx

dbeguin

I started a review but I see that there is still conflicts markers inside your commit, So I suggest to first get rid of them (edit commit by commit to see them) before I review the rest. :) ping me once done
again, if you have questions, feel free to ask :)

dbeguin · 2025-03-24T08:35:53Z

realestatinator/models/__init__.py

@@ -1,3 +1,8 @@
 # -*- coding: utf-8 -*-


you can remove all the utf-8 header lines, not needed since we're in python3

dbeguin · 2025-03-24T08:36:14Z

realestatinator/models/__init__.py

@@ -1,3 +1,8 @@
 # -*- coding: utf-8 -*-

+from . import res_users


alphabetical order

dbeguin · 2025-03-24T08:36:53Z

realestatinator/models/estate_property.py

-	_order = 'sequence'
+	_order = 'id desc'
+	_sql_constraints = [
+		('check_expected_price_positive', 'CHECK (0 < expected_price)', 'Check that the expected price is strictly positive'),


please fix your indentations (4 whitespaces per indent)

dbeguin · 2025-03-24T08:43:50Z

realestatinator/models/estate_property.py

+	garden = fields.Boolean('Garden')
+	garden_area = fields.Integer('Garden Area')
+	garden_orientation = fields.Selection(string='Garden Orientation', selection=[
+		('N', 'North'), 


use lowercase for technical names, and be explicit, 'north' instead of 'N'. We always like explicit code more than super compacted code that is unreadable.

dbeguin · 2025-03-24T10:44:30Z

realestatinator/models/estate_property_offer.py

+	status = fields.Selection(string='Status', selection=[
+		('accepted', 'Accepted'), 
+		('refused', 'Refused')
+	], copy=False)


usually, we define selection field by giving directly the selection param without naming it.

status = fields.Selection([ ('accepted', 'Accepted'), ('refused', 'Refused') ], string='Status', copy=False)

dbeguin · 2025-03-24T10:51:49Z

realestatinator/models/estate_property_offer.py

@@ -0,0 +1,56 @@
+from odoo import api, exceptions, fields, models
+


2 empty lines before class. apply this everywhere

dbeguin · 2025-03-24T10:52:46Z

realestatinator/models/estate_property_offer.py

+	_name = 'estate.property.offer'
+	_description = 'estate property offer'
+	_order = 'price desc'
+	_sql_constraints = [


_sql_constraints are put after field definitions

dbeguin · 2025-03-24T10:53:40Z

realestatinator/models/estate_property_offer.py

+	], copy=False)
+	partner_id = fields.Many2one('res.partner', string='Partner')
+	property_id = fields.Many2one('estate_property', string='Property')
+	validity = fields.Integer('Validity', default=7)


could be nice to add an helper (help='') to tell that validity is expressed in days.
or change validity field into validity_days

dbeguin · 2025-03-24T10:55:17Z

realestatinator/views/estate_property_offer_views.xml

@@ -0,0 +1,54 @@
+<?xml version="1.0"?>
+<odoo>
+<<<<<<< HEAD


you have conflicts markers here.
check other files
maybe you don't see in final diff by working commit by commit will display you those markers
Each commit should be clean and contain changes as if they were the last commit of your branch. Like what if we revert the commits after this one ?

Please kill me so I never have to do this again.

dbeguin

Zblip !

dbeguin · 2025-03-24T14:38:25Z

realestatinator/models/estate_property_offer.py

+
+	def _inverse_deadline(self):
+		for record in self:
+			delta = record.date_deadline - record.creation_date


no need a variable here

dbeguin · 2025-03-25T12:43:19Z

realestatinator/models/__init__.py

 from . import estate_property_offer
+from . import estate_property_tags


those changes should not be in that commit

dbeguin · 2025-03-25T12:44:29Z

realestatinator/models/estate_property.py

+	_name = 'estate_property'
+	_description = 'real estate property'
+	_order = 'id desc'
+	_sql_constraints = [


_sql_constraints are placed after field definition (that's the only exception for private attributes)

dbeguin · 2025-03-25T12:45:13Z

realestatinator/models/estate_property.py

@@ -0,0 +1,109 @@
+from odoo import api, exceptions, fields, models
+


two empty lines before class

dbeguin · 2025-03-25T12:45:55Z

realestatinator/models/estate_property.py

+	selling_price = fields.Float('Selling Price', readonly=True, copy=False)
+	bedrooms = fields.Integer('Bedrooms', default=2)
+	living_area = fields.Integer('Living Area')
+	facades = fields.Integer('Facades')


usually when a field is basically a counter, you postfix with '_count'
because 'facade' only is not specific enough

dbeguin · 2025-03-25T12:57:47Z

realestatinator/models/estate_property.py

+
+	@api.onchange('garden')
+	def _set_garden_properties(self):
+		for record in self:


we try to be more explicit. record is too generic.
Here we are manipulating properties, so name it : for property in self.
apply this logic everywhere

dbeguin · 2025-03-25T13:00:23Z

realestatinator/models/estate_property_offer.py

+			record.property_id.buyer = record.partner_id
+	@api.model
+	def create(self, vals):
+		estate_property = self.env['estate_property'].browse(vals["property_id"])


will if property_id not in vals (well here it's a mandatory field so it should always be set, but that should not blow up by you code, but by the ORM check on required fields instead)

dbeguin · 2025-03-25T13:09:42Z

realestatinator/models/estate_property_offer.py

+	@api.model
+	def create(self, vals):


create methods should be multi.
see 'create_multi' for examples

dbeguin · 2025-03-25T13:10:36Z

realestatinator/models/estate_property_offer.py

+		if estate_property.state == 'new':
+			estate_property.state = 'offer_received'


I would do that after to write on every offer properties at the same time as this is the same value for all.

dbeguin · 2025-03-25T13:52:42Z

realestatinator/models/estate_property_type.py

+	offer_ids = fields.One2many('estate.property.offer', 'property_type_id', string='Offers')
+	offer_count = fields.Integer(string='Offer Count', compute='_count_offers')
+
+


remove useless empty line

dbeguin · 2025-03-25T14:57:22Z

realestatinator/models/estate_property.py

+    def mark_cancelled(self):
+        for record in self:
+            if record.state == 'cancelled':
+                raise exceptions.UserError('This property is already cancelled.')


user errors should be translated. use _("yourtext") to allow translations

gato-odoo closed this Mar 20, 2025

gato-odoo reopened this Mar 20, 2025

gato-odoo force-pushed the 18.0-gato-tutorials branch from cea047a to da2ea25 Compare March 20, 2025 16:04

gato-odoo force-pushed the 18.0-gato-tutorials branch from 27ab2cd to 979ca12 Compare March 24, 2025 08:47

gato-odoo added 6 commits March 24, 2025 10:12

[ADD] realestatinator: Helps you manage real estate properties.

426b023

[ADD] estateaccountinator: Helps you manage accouts related to real e…

2aac821

…state properties.

[ADD] Counter: a simple counter

7538bd8

A simple counter component that increases when its button is clicked task-xxxxx

[ADD] Card: a basic card component

1b00261

A basic card component with a title and a description task-xxxxx

[ADD] TodoList and TodoItem: Components to manage a todo list and its…

df99155

… items task-xxxxx

[IMP] Card: modified Card component to use default slot.

a10a151

gato-odoo force-pushed the 18.0-gato-tutorials branch from 979ca12 to a10a151 Compare March 24, 2025 09:15

[IMP] Card: Modified Card component to make it collapsable

bd151e8

dbeguin reviewed Mar 24, 2025

View reviewed changes

gato-odoo added 2 commits March 24, 2025 13:19

[IMP] dashboard: Added Layout and two action buttons

c03fee4

[IMP] awesome_dashboard: added pie chart.

2dcfb8f

Please kill me so I never have to do this again.

gato-odoo force-pushed the 18.0-gato-tutorials branch from d486f83 to 2dcfb8f Compare March 24, 2025 16:43

dbeguin reviewed Mar 25, 2025

View reviewed changes

gato-odoo added 3 commits March 27, 2025 10:31

[IMP] awesome_dashboard: load cards from registry

b80c8df

[FIX] awesome_dashboard: Fixed error on updating pie chart

b43ff98

[FIX] awesome_dashboard: Fixed error on updating pie chart. Again.

7f83284

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18.0 gato tutorials #657

18.0 gato tutorials #657

gato-odoo commented Mar 20, 2025

robodoo commented Mar 20, 2025

gato-odoo commented Mar 24, 2025

dbeguin left a comment

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin Mar 24, 2025

dbeguin left a comment

dbeguin Mar 24, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

dbeguin Mar 25, 2025

		@@ -1,3 +1,8 @@
		# -- coding: utf-8 --

		from . import res_users

		@@ -0,0 +1,56 @@
		from odoo import api, exceptions, fields, models

		from . import estate_property_offer
		from . import estate_property_tags

		@@ -0,0 +1,109 @@
		from odoo import api, exceptions, fields, models

		if estate_property.state == 'new':
		estate_property.state = 'offer_received'

		offer_ids = fields.One2many('estate.property.offer', 'property_type_id', string='Offers')
		offer_count = fields.Integer(string='Offer Count', compute='_count_offers')

18.0 gato tutorials #657

Are you sure you want to change the base?

18.0 gato tutorials #657

Conversation

gato-odoo commented Mar 20, 2025

robodoo commented Mar 20, 2025

gato-odoo commented Mar 24, 2025

dbeguin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbeguin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment