[ADD] hr_payroll_tds: Introduced Tax Declaration Sub-menu #650

siha-odoo · 2025-03-19T12:54:04Z

With this commit

Added a Tax Declaration sub-menu under the Contracts menu, allowing users to define new TDS declarations.
Introduced a "Generate Declarations" button in the TDS declaration form, opening a wizard for selecting employees.
Implemented four selection modes for employee filtering:
- By Employee
- By Department
- By Job Position
- By Salary Structure
Based on the selected mode, the relevant field (e.g., list of departments for "By Department") is dynamically displayed.
Employees are filtered according to the selected criteria, ensuring that only those with valid contracts are included.
TDS Declaration Form Enhancements:
- A stat button now displays the count of generated tax declarations.
- Clicking the stat button opens a list view of the generated declarations.
- Clicking on a specific declaration opens its form view for detailed review.
TDS Calculation & Deductions:
- The Tax Declaration tab in the form now computes TDS based on the New Tax Regime and an employee’s total income.
- Added an "Other Deductions" tab to manage additional deductions.
Integration with Employee Form:
- A TDS Declaration stat button is now available on the Employee form.
- Clicking it opens a list of TDS declarations related to the selected employee.

robodoo · 2025-03-19T12:54:07Z

kais-odoo

Thank you for your work! This is a substantial codebase, so I’m providing the first round of review.

kais-odoo · 2025-04-09T06:13:49Z

hr_payroll_tds/models/hr_employee.py

+        """Opens the TDS Declarations associated with the current employee."""
+
+        action = self.env["ir.actions.actions"]._for_xml_id("hr_payroll_tds.action_open_declarations")
+        target_ids = self.env["hr.tds.declaration.details"].search([("employee_id", "=", self.id)])


If there is a large amount of data, more than 1000 declarations, during a certain period, does that mean it impacts performance when clicking on the button takes extra time?

Yes, it can impact performance if there more data to load. but I think making field indexed can optimize performance even for large dataset.

kais-odoo · 2025-04-09T06:17:04Z

hr_payroll_tds/models/hr_tds_declaration.py

+        return [(previous_year, previous_year), (current_financial_year, current_financial_year)]
+
+    name = fields.Char(string="TDS Declaration", required=True)
+    tds_declaration_ids = fields.One2many("hr.tds.declaration.details", "tds_declaration_id")


TDS comes under the indian localization just for your knowledge we prefer to define field with l10n_in prefix

kais-odoo · 2025-04-09T06:20:35Z

hr_payroll_tds/models/hr_tds_declaration.py

+        if self.financial_year:
+            start_year = int(self.financial_year.split("-")[0])
+            end_year = int(self.financial_year.split("-")[1])
+            self.start_date = fields.Date.to_date(f"{start_year}-04-01")


this will crash when there are multiple records. Computation should always iterate within the loop

Thanks for the insight. I will modify.

kais-odoo · 2025-04-09T06:20:51Z

hr_payroll_tds/models/hr_tds_declaration.py

+            self.end_date = fields.Date.to_date(f"{end_year}-03-31")
+
+    def _compute_declarations_count(self):
+        self.tds_declaration_count = len(self.tds_declaration_ids)


kais-odoo · 2025-04-09T06:23:00Z

hr_payroll_tds/models/hr_tds_declaration.py

+    def _compute_declarations_count(self):
+        self.tds_declaration_count = len(self.tds_declaration_ids)
+
+    def action_approved(self):


You should use self.ensure_one() at the beginning of the method, as it is designed for singleton actions.

kais-odoo · 2025-04-09T07:02:36Z

hr_payroll_tds/views/hr_tds_declaration_views.xml

l10n_in prefix on record id that is preferable

kais-odoo · 2025-04-09T07:04:24Z

hr_payroll_tds/views/report_tds_declaration_template.xml

+        <t t-call="web.external_layout">
+            <div class="page">
+                <h5 id="tax_declaration_name">
+                    <span t-esc="o.name"/> - Tax Declaration


Suggested change

<span t-esc="o.name"/> - Tax Declaration

<span t-out="o.name"/> - Tax Declaration

t-esc is deprecated

kais-odoo · 2025-04-09T07:05:24Z

hr_payroll_tds/views/report_tds_declaration_template.xml

+<?xml version="1.0"?>
+<odoo>
+    <template id="report_tax_declaration">
+        <t t-call="web.external_layout">


what is purpose of making tds external_layout on report?

In order to get default company information , logo , header & footer. So that we should not have to set it manually.

kais-odoo · 2025-04-09T07:10:08Z

hr_payroll_tds/views/report_tds_declaration_template.xml

+                                <td>
+                                    <div id="employee_name">
+                                        <strong class="me-2">Name:</strong>
+                                        <span t-field="o.employee_id.name"/>


why not using t-out just to show something?

Earlier I believed that field like many2one also should be shown by t-field. But i have cleared my assumption that t-field should be used if field needs any formatting.

kais-odoo · 2025-04-09T07:12:41Z

hr_payroll_tds/views/report_tds_declaration_template.xml

+                                    </div>
+                                    <div id="employee_department">
+                                        <strong class="me-2">Department:</strong>
+                                        <span t-field="o.employee_id.department_id.name"/>


for formatting or using widget in template t-field is good to go with but just display string t-out would be a good option not sure about translation you can have look into it.

Thanks for the insight, I will take look into that.

With this commit ================ - Added a Tax Declaration sub-menu under the Contracts menu, allowing users to define new TDS declarations. - Introduced a "Generate Declarations" button in the TDS declaration form, opening a wizard for selecting employees. - Implemented four selection modes for employee filtering: - By Employee - By Department - By Job Position - By Salary Structure - Based on the selected mode, the relevant field (e.g., list of departments for "By Department") is dynamically displayed. - Employees are filtered according to the selected criteria, ensuring that only those with valid contracts are included. - TDS Declaration Form Enhancements: - A stat button now displays the count of generated tax declarations. - Clicking the stat button opens a list view of the generated declarations. - Clicking on a specific declaration opens its form view for detailed review. - TDS Calculation & Deductions: - The Tax Declaration tab in the form now computes TDS based on the New Tax Regime and an employee’s total income. - Added an "Other Deductions" tab to manage additional deductions. - Integration with Employee Form: - A TDS Declaration stat button is now available on the Employee form. - Clicking it opens a list of TDS declarations related to the selected employee.

siha-odoo force-pushed the 18.0-tds-declaration-siha branch 2 times, most recently from cac9c44 to 09411bd Compare March 25, 2025 04:59

kais-odoo reviewed Apr 9, 2025

View reviewed changes

siha-odoo force-pushed the 18.0-tds-declaration-siha branch 2 times, most recently from bf3b6e3 to 7f46486 Compare April 10, 2025 06:52

siha-odoo force-pushed the 18.0-tds-declaration-siha branch from 7f46486 to 5294478 Compare April 10, 2025 06:57

	<span t-esc="o.name"/> - Tax Declaration
	<span t-out="o.name"/> - Tax Declaration

[ADD] hr_payroll_tds: Introduced Tax Declaration Sub-menu #650

Are you sure you want to change the base?

[ADD] hr_payroll_tds: Introduced Tax Declaration Sub-menu #650

Conversation

siha-odoo commented Mar 19, 2025

With this commit

Uh oh!

robodoo commented Mar 19, 2025

Uh oh!

kais-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siha-odoo Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

siha-odoo Apr 10, 2025 •

edited

Loading