[FIX] 18.0 Module Awesome_Gallery setup creates error #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorentinVermeulen
force-pushed
the
18.0-fix-awesome-gallery-tutorial
branch
from
a742f0b to
8753897
Compare
CorentinVermeulen
changed the title
=================== Steps to Reproduce: =================== 1. Checkout the origin/18.0 branch for the tutorial repo and install the Awesome_Gallery module. 2. Try to reconnect, you get and error with following traceback: `... File "/home/odoo/work/odoo/addons/web/models/ir_ui_view.py", line 14, in <dictcomp> 'icon': _view_info[type_]['icon'], KeyError: 'gallery' ` 3. Try applying the first step of solution 6.1 from the origin/18.0-solutions branch. The error persists and you cannot do the tutorial. ================== After this commit: ================== The module can be installed without errors, and you can proceed with the tutorial without issues. Note: The 18.0-solutions branch should be updated with the new v18 tutorial, which now focuses on the Contact app instead of the Awesome_Tshirt app. task-xxxx
CorentinVermeulen
force-pushed
the
18.0-fix-awesome-gallery-tutorial
branch
from
8753897 to
cb7eef6
Compare
|
|
|
@CorentinVermeulen I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce:
... File "/home/odoo/work/odoo/addons/web/models/ir_ui_view.py", line 14, in <dictcomp> 'icon': _view_info[type_]['icon'], KeyError: 'gallery'After this commit:
The module can be installed without errors, and you can proceed with the tutorial without issues. Note: The 18.0-solutions branch should be updated with the new v18 tutorial, which now focuses on the Contact app instead of the Awesome_Tshirt app.
task-xxxx