[ADD] estate: created new module #1020

haahi-odoo · 2025-11-05T06:56:29Z

Initializes the basic structure for the real estate module.

Creates the module scaffolding (manifest, init, and base directories).
Defines the initial 'estate.property' model.
Adds base fields (columns) to the new model.

Initializes the basic structure for the real estate module. - Creates the module scaffolding (manifest, init, and base directories). - Defines the initial 'estate.property' model. - Adds base fields (columns) to the new model.

robodoo · 2025-11-05T06:56:32Z

- Set default values for estate.property model fields. - Apply additional field attributes (e.g., readonly, required). - Register menu items to access the tree and form views.

- added basic, list and form view - also added filter for new or offer received stage

- pincode feild name had spelling mistake in views/estate_property_views.xml

…nctionality -Developed and integrated list, form, and search views for the Real Estate module -Including support for group-by operations.

bit-odoo

Hello,
Good Job!
I have left some remarks.

please update your commit message and title. you can refer this documentation :- https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#commit-message-full-description

bit-odoo · 2025-11-07T11:19:09Z

estate/__manifest__.py

+    'application': True,
+    'installable': True,
+    'author': 'Odoo S.A.',
+    'category':'Tutorials',


Suggested change

'category':'Tutorials',

'category': 'Tutorials',

bit-odoo · 2025-11-07T11:19:31Z

estate/__manifest__.py

+        'views/estate_menus.xml',
+    ],
+}
+


An empty line should be without whitespace.

bit-odoo · 2025-11-07T11:19:48Z

estate/models/estate_property.py

+        copy=False,
+        default='new'
+    )
+


An empty line should be without whitespace.

bit-odoo · 2025-11-07T11:21:38Z

estate/models/estate_property.py

+    description = fields.Text("Description")
+    postcode = fields.Char("Postcode", required=True)
+    date_availability = fields.Date("Availability Date", default=fields.Date.today()+relativedelta(months=3))
+    expected_price = fields.Float(required=True)
+    selling_price = fields.Float("Selling Price", readonly=True)
+    bedrooms = fields.Integer("Bedrooms", default=2)
+    living_area = fields.Integer("living_area(sqm)")
+    facades = fields.Integer("Facades")
+    garage = fields.Boolean("Garage")
+    garden = fields.Boolean("Garden")


By default, Odoo generates a string. If your string is the same as the technical name, then no need to add.

bit-odoo · 2025-11-07T11:22:31Z

estate/views/estate_menus.xml

+    <menuitem id="estate_advertisement_menu"
+              name="Advertisements"
+              parent="estate_root_menu"/>


Suggested change

<menuitem id="estate_advertisement_menu"

name="Advertisements"

parent="estate_root_menu"/>

<menuitem id="estate_advertisement_menu"

name="Advertisements"

parent="estate_root_menu"/>

bit-odoo · 2025-11-07T11:24:05Z

estate/views/estate_property_views.xml

@@ -0,0 +1,90 @@
+


unnecessary diff.

bit-odoo · 2025-11-07T11:24:56Z

estate/views/estate_property_views.xml

+                <filter name="group_by_postcode"
+                        string="Group by Postcode"
+                        context="{'group_by': 'postcode'}"/>
+


unnecessary diff.

bit-odoo · 2025-11-07T11:25:03Z

estate/views/estate_property_views.xml

+            <search string="Search Properties">
+                <field name="name"/>
+                <field name="postcode"/>
+


unnecessary diff.

bit-odoo · 2025-11-07T11:25:43Z

estate/views/estate_property_views.xml

+                <filter name="group_by_postcode"
+                        string="Group by Postcode"
+                        context="{'group_by': 'postcode'}"/>


proper indentation needed.

bit-odoo · 2025-11-07T11:26:10Z

estate/views/estate_property_views.xml

+    </record>
+
+
+</odoo>


There should be one empty line at the end of the file.

-Introduced Property Type and Property Tag models. -Added Buyer and Salesperson fields. -Implemented the Property Offer model.

-Added computed fields with inverse functions and onchange methods, -Improved real estate module with sold and cancel buttons to enhance the module functionality.

-Implemented new sql constraint method.

…Options. -Implemented inline views and widgets to enhance the user interface within the Real Estate module. -Introduced list-ordering functionality to improve the organization and sorting of listings. -Added attribute and option configurations to increase customization capabilities and overall flexibility for users.

bit-odoo

Hello!
Another round of review :)
I have made some comments; please have a look at them.

Please update your commit message Bootstrap new 'estate' module and PR title too.

bit-odoo · 2025-11-12T08:02:35Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+from odoo import models, fields, api
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero


Suggested change

from dateutil.relativedelta import relativedelta

from odoo import models, fields, api

from odoo.exceptions import UserError, ValidationError

from odoo.tools.float_utils import float_compare, float_is_zero

from dateutil.relativedelta import relativedelta

from odoo import models, fields, api

from odoo.exceptions import UserError, ValidationError

from odoo.tools.float_utils import float_compare, float_is_zero

bit-odoo · 2025-11-12T08:58:19Z

estate/models/estate_property.py

+                if record.garden_area == 10:
+                    record.garden_orientation = "north"
+                elif record.garden_area == 20:
+                    record.garden_orientation = "east"
+                elif record.garden_area == 30:
+                    record.garden_orientation = "west"
+                elif record.garden_area == 40:
+                    record.garden_orientation = "south"
+                else:


Is this necessary?

bit-odoo · 2025-11-12T09:01:12Z

estate/views/estate_property_views.xml

+                            <field name="bedrooms" />
+                            <field name="living_area" />
+                            <field name="facades" />
+                            <field name="garage" />
+                            <field name="garden" />
+                            <field name="garden_area" invisible="not garden" />
+                            <field name="garden_orientation" invisible="not garden" />


This part should be in the description tab.

bit-odoo · 2025-11-12T09:02:53Z

estate/models/estate_property.py

+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'The expected price must be strictly positive.'
+    )
+
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price > 0)',
+        'The selling price must be positive.'
+    )


Constraints should be after the field declaration; you can take reference from the Odoo codebase.

bit-odoo · 2025-11-12T09:04:24Z

estate/models/estate_property_offer.py

+    _check_offer_price = models.Constraint(
+        'CHECK(price > 0)',
+        'The price must be strictly positive.'
+    )


same and should be one empty line at the end of the file.

bit-odoo · 2025-11-12T09:05:26Z

estate/models/estate_property_type.py

+    _check_type_name_unique = models.Constraint(
+        'UNIQUE(name)', 
+        'The name of the property type must be unique.'
+    )


Should be one empty line at the end of the file.

bit-odoo · 2025-11-12T09:08:22Z

estate/views/estate_property_offer_views.xml

+                decoration-success="status == 'accepted'" editable="bottom">
+                <field name="price" />
+                <field name="partner_id" />
+                <field name="status" invisible="1" />


Why invisible in the list view? If it is invisible, then you can remove it from the list view.

-Introduced a stat button on Property Type to display related offer count. -Restricted property deletion to New or Cancelled states, set status to Offer Received on offer creation, and prevented creation of offers lower than existing ones.

haahi-odoo added 2 commits November 4, 2025 17:00

[ADD] estate: Bootstrap new 'estate' module

f9e58d2

Initializes the basic structure for the real estate module. - Creates the module scaffolding (manifest, init, and base directories). - Defines the initial 'estate.property' model. - Adds base fields (columns) to the new model.

[ADD] estate: Bootstrap new 'estate' module

a8b1737

Initializes the basic structure for the real estate module. - Creates the module scaffolding (manifest, init, and base directories). - Defines the initial 'estate.property' model. - Adds base fields (columns) to the new model.

haahi-odoo added 5 commits November 5, 2025 18:49

[IMP] Estate Configure field defaults and UI menus

b1d4714

- Set default values for estate.property model fields. - Apply additional field attributes (e.g., readonly, required). - Register menu items to access the tree and form views.

[IMP] estate : Added list & form view

5ddda6c

- added basic, list and form view - also added filter for new or offer received stage

[FIX] estate : mismatch field name

c0bc17c

- pincode feild name had spelling mistake in views/estate_property_views.xml

[FIX]: indentation Error

5d220be

[IMP] estate: Implement list, form, and search views with grouping fu…

a3a92c5

…nctionality -Developed and integrated list, form, and search views for the Real Estate module -Including support for group-by operations.

bit-odoo reviewed Nov 7, 2025

View reviewed changes

haahi-odoo added 5 commits November 7, 2025 17:42

[IMP] Real Estate: Enhanced Data Models and Functionalities

fa72a21

-Introduced Property Type and Property Tag models. -Added Buyer and Salesperson fields. -Implemented the Property Offer model.

[IMP] estate: added computed fields,inverse fun & onchange

cdd4d91

-Added computed fields with inverse functions and onchange methods, -Improved real estate module with sold and cancel buttons to enhance the module functionality.

[FIX] estate: fixed depreciated sql contraint

459d53d

-Implemented new sql constraint method.

[FIX] estate: fixed depreciated sql contraint

c77f123

-Implemented new sql constraint method.

bit-odoo reviewed Nov 12, 2025

View reviewed changes

haahi-odoo changed the title ~~[ADD] estate: Bootstrap new 'estate' module~~ [ADD] estate: created new module Nov 12, 2025

		</record>


		</odoo> No newline at end of file

[ADD] estate: created new module #1020

Are you sure you want to change the base?

[ADD] estate: created new module #1020

Uh oh!

Conversation

haahi-odoo commented Nov 5, 2025

Uh oh!

robodoo commented Nov 5, 2025

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bit-odoo left a comment •

edited

Loading