[ADD] awesome_owl module #1009
Open
[ADD] awesome_owl module #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alan-odoo
reviewed
Oct 29, 2025
| @@ -1,10 +0,0 @@ | |||
| /** @odoo-module **/ | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't be in your PR as this file has never been merge with any deployed branch. Same for the other files you removed.
awesome_owl/static/src/card/card.js
Outdated
| import { Component, useState } from "@odoo/owl"; | ||
|
|
||
| export class Card extends Component { | ||
| static template = "awesome_owl.card"; |
There was a problem hiding this comment.
So, yes static template = "awesome_owl.playground"; should be static template = "awesome_owl.Playground"; this mistake is in the tutorial code and not in yours.
Suggested change
| static template = "awesome_owl.card"; | |
| static template = "awesome_owl.Card"; |
| import { Component, useState } from "@odoo/owl"; | ||
|
|
||
| export class Counter extends Component { | ||
| static template = "awesome_owl.counter"; |
There was a problem hiding this comment.
Suggested change
| static template = "awesome_owl.counter"; | |
| static template = "awesome_owl.Counter"; |
| import { Component, useState } from "@odoo/owl"; | ||
|
|
||
| export class TodoItem extends Component { | ||
| static template = "awesome_owl.todo_item"; |
There was a problem hiding this comment.
Suggested change
| static template = "awesome_owl.todo_item"; | |
| static template = "awesome_owl.TodoItem"; |
| import { TodoItem } from "./todo_item"; | ||
|
|
||
| export class TodoList extends Component { | ||
| static template = "awesome_owl.todo_list"; |
There was a problem hiding this comment.
Suggested change
| static template = "awesome_owl.todo_list"; | |
| static template = "awesome_owl.TodoList"; |
awesome_owl/static/src/playground.js
Outdated
| this.state.sum++; | ||
| } | ||
|
|
||
| static components = { Counter, Card, TodoList }; |
There was a problem hiding this comment.
The static fields should be placed at the the top of your class just before the methods.
| }; | ||
|
|
||
| toggleState() { | ||
| this.props.todo.isCompleted = !this.props.todo.isCompleted |
There was a problem hiding this comment.
Do not forget ; at the end of your line. It's good js practice as it may prevent some errors.
| @@ -0,0 +1,2 @@ | |||
| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.