WIMAR - Onboarding #1005
Open
WIMAR - Onboarding #1005
+399
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thcl-odoo
reviewed
Oct 23, 2025
There was a problem hiding this comment.
First set of comments :) Overall, it's fine!
Here are a few general comments:
- Try to be consistent with the use of single quotes
'and". If you start using one of them, be consistent throughout :) - Be careful with commit conventions (you can check the documentation here: Documentation )
For example [ADD] Chapter 1: Init and manifest => [ADD] estate: app creation
[ADD] Chapter 3: Models and Basic Fields => [IMP] estate: add models & basic fields etc.
Create empty __init__.py and __manifest__.py with module name, set as application.
Created the Estate Property model and added it to the __init__.py file. Defined the model’s attributes and fields.
Created access rights granting full permissions to base.group_user and added them to the __manifest__.py file.
Created the first action and menu, and added them to the __manifest__.py file. Linked the action to the menu.
- Added custom views: List, Form, and Search - Fixed empty line at EOF to comply with PEP8
wimar-odoo
force-pushed
the
19.0-onboarding-wimar
branch
from
8e27485 to
bd3010f
Compare
wimar-odoo
force-pushed
the
19.0-onboarding-wimar
branch
from
bd3010f to
db9ded5
Compare
- Added property types such as House, Apartment, etc., with corresponding Menus, Actions, and Views - Added property tags such as Renovated, etc., with corresponding Menus, Actions, and Views - Added an Offers tab on properties to display all offers related to a specific property
- Added computed, inverse, and onchange fields to improve user convenience and automation: total_area, best_price, validity, date_deadline, and garden
- Added buttons to sell or cancel a property, and to accept or refuse an offer
- Added SQL constraints to ensure positive prices and unique names - Added Python constraints to enforce offers at least 90% of the expected price
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.