Skip to content

Conversation

Wajih-Wanis
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Oct 20, 2025

Pull request status dashboard

@Wajih-Wanis Wajih-Wanis changed the title [ADD]estate :create the app WAOUN ONBOARDING Oct 20, 2025
@Wajih-Wanis Wajih-Wanis changed the title WAOUN ONBOARDING WAOUN Onboarding Oct 20, 2025
@Mathilde411 Mathilde411 requested a review from dery-odoo October 20, 2025 12:55
@Wajih-Wanis Wajih-Wanis force-pushed the 19.0-onboarding-waoun branch from 1e44f72 to 8f77002 Compare October 20, 2025 13:53
Copy link

@dery-odoo dery-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comment, make sure to keep your branch green on the runbot.
Keep up the good work :)


name = fields.Char('Type', required=True)
description = fields.Text('Description')

No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a whitespace on the newline here

access_estate_property,estate.property,model_estate_property,base.group_user,1,1,1,1
access_estate_property_type,estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
access_buyer,buyer,model_buyer,base.group_user,1,1,1,1
access_salesperson,sales,model_salesperson,base.group_user,1,1,1,1 No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newline is missing here

_description = "Estate Property Type"

name = fields.Char('Type', required=True)
description = fields.Text('Description')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string is generated from the variable name so no need to duplicate it here

<menuitem id="estate_type_model_menu_action" action="estate_property_type_model_action"/>
</menuitem>
</menuitem>
</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline missing

<field name="view_mode">list,form</field>
</record>

</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline missing

</record>


</odoo> No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline missing

_description = "Estate property"

name = fields.Char('Title', required=True)
description = fields.Text('Description', required=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string is generated from the variable name so no need to duplicate it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants