Signal #1700
Open
Signal #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-odoo
reviewed
Oct 3, 2025
src/runtime/reactivity.ts
Outdated
Comment on lines
131
to
134
| Promise.resolve().then(() => { | ||
| scheduled = false; | ||
| processAtoms(); | ||
| }); |
There was a problem hiding this comment.
If I understand this correctly, asynchronous state at the lowest level is really not ideal, this will make the code extremely complex if we need to wait something whenever we write a value before accessing dependent values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the reactivity system in Owl