Master enhance pivot formula pro #6414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
May 14, 2025
| @@ -368,7 +368,7 @@ describe("Pivot fix formula menu item", () => { | |||
| test("Fixing the formula take into account the arguments of PIVOT()", () => { | |||
| // prettier-ignore | |||
| const grid = { | |||
| A1: "Customer", B1: "Price", C1: "Date", E1: "=PIVOT(1, 1, false, false, 1)", | |||
| A1: "Customer", B1: "Price", C1: "Date", E1: "=PIVOT(1, 1, false, false, 1, false)", | |||
There was a problem hiding this comment.
Why this change ? You change the result of the pivot function in the test (now the measure isn't shown), but the test didn't have to change ?
There was a problem hiding this comment.
Nvm I understood, before hiding the headers also hid the measures. The change might break some spreadsheets then ? Are we fine with that ?
There was a problem hiding this comment.
Yes it might break some spreadsheets, and from what we discussed yesterday with @LucasLefevre it was fine.
Another solution is to make this new attribute false by default and did not take it into account if include_columns_title is true to keep the current behavior, but meh...
As soon as it's not a traceback, I think I will be able to sleep tonight
pro-odoo
force-pushed
the
master-enhance-pivot-formula-pro
branch
from
effc60c to
a7f3dea
Compare
pro-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jun 2, 2025
Before this commit, the pivot formula id was displayed with the title in the pivot formula (top-left). Now, the title is only the name of the pivot. Task: 4793572
This commit prepares the ground for the introduction of a new parameter to the pivot formula to display or hide the measures row. Task: 4793572
With this commit, one can now hide the columns headers rows without hiding the measures row one, by adding a new parameter to the pivot formula. This will be useful in our Odoo dashboards. Task: 4793572
pro-odoo
force-pushed
the
master-enhance-pivot-formula-pro
branch
from
a7f3dea to
850c6f2
Compare
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Jun 12, 2025
Before this commit, the pivot formula id was displayed with the title in the pivot formula (top-left). Now, the title is only the name of the pivot. Task: 4793572 Part-of: #6414 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 12, 2025
This commit prepares the ground for the introduction of a new parameter to the pivot formula to display or hide the measures row. Task: 4793572 Part-of: #6414 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 12, 2025
With this commit, one can now hide the columns headers rows without hiding the measures row one, by adding a new parameter to the pivot formula. This will be useful in our Odoo dashboards. closes #6414 Task: 4793572 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
pro-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Jun 12, 2025
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jun 13, 2025
See odoo/o-spreadsheet#6414 closes #213952 Task: 4793572 Related: odoo/enterprise#87495 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist