[FIX] selection: allow to de-select a zone #6125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
requested changes
Apr 30, 2025
| const anchor = event.anchor; | ||
| let zones: Zone[] = []; | ||
| let anchor = event.anchor; | ||
| let zones: Zone[] = [...this.gridSelection.zones]; |
There was a problem hiding this comment.
so you make a change on the fly and use the "updateSelection" after a previous event to 'fix' things?
There was a problem hiding this comment.
In the current flow, all events directly update gridSelection.zones on mouse down and drag. updateSelection is triggered after the mouse up event to correct the selection by checking if the zone already exists or overlaps.
In GSheet, zones are updated only on mouse up to avoid redundant updates during drag. On mouse up, updateSelection compares anchor.zone with existing gridSelection.zones: if present, it removes it; if overlapping, it splits; otherwise, it adds the new zone.
Let me know which approach we should go with.
rmbh-odoo
force-pushed
the
master-imp-allow-to-de-select-zone-rmbh
branch
from
f53a3dd to
c20c185
Compare
Before this commit: - Ctrl+Click on a selected cell had no effect. - Users could add to the selection but couldn't remove cells or zones. Issue Example: 1. Select range A1:C3. 2. Ctrl+Click on B2. 3. Expected: Selection splits into A1:C1, A2, C2, A3:C3. 4. Previously, Ctrl+Click did not deselect B2. After this commit: - Ctrl+Click on a selected cell now removes it. - The selection splits into separate zones as needed. Technical Changes: - UpdateSelection is now triggered on mouseup. - The selection logic removes the zone from any existing selection zones. - Splits overlapping zones into non-overlapping parts. Task: 4647187
rmbh-odoo
force-pushed
the
master-imp-allow-to-de-select-zone-rmbh
branch
from
c20c185 to
f2f9ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Before this pr:
Issue Example:
After this pr:
Technical Changes:
Task: 4647187
review checklist