[ADD] thrift_store: add module #1064
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frva-odoo
changed the title
frva-odoo
force-pushed
the
master-thrift-store-frva
branch
from
de26e2e to
d85a138
Compare
Adding the Thrift Store module: sell products with the POS and organize your store with the Planning and Employees App.
frva-odoo
force-pushed
the
master-thrift-store-frva
branch
from
d85a138 to
f8cf0fe
Compare
vava-odoo
requested changes
Sep 11, 2025
Comment on lines
+6
to
+15
| 'appointment_account_payment', | ||
| 'base_industry_data', | ||
| 'hr_sign', | ||
| 'knowledge', | ||
| 'planning', | ||
| 'pos_online_payment', | ||
| 'project', | ||
| 'sale', | ||
| 'stock', | ||
| 'survey', |
There was a problem hiding this comment.
Reading the task, I don't see any trace of Appointment, Project, Sale, Sign & Survey. Could you confirm?
Suggested change
| 'appointment_account_payment', | |
| 'base_industry_data', | |
| 'hr_sign', | |
| 'knowledge', | |
| 'planning', | |
| 'pos_online_payment', | |
| 'project', | |
| 'sale', | |
| 'stock', | |
| 'survey', | |
| 'base_industry_data', | |
| 'hr', | |
| 'knowledge', | |
| 'planning', | |
| 'pos_online_payment', | |
| 'stock', |
| { | ||
| 'name': 'Thrift Store', | ||
| 'version': '1.0', | ||
| 'category': 'Services', |
There was a problem hiding this comment.
Suggested change
| 'category': 'Services', | |
| 'category': 'Retail', |
| <?xml version='1.0' encoding='UTF-8'?> | ||
| <odoo> | ||
| <template id="welcome_article_body"> | ||
| <h1 data-heading-link-id="379843998856" data-oe-version="2.0">Odoo for Thrift Store</h1> |
There was a problem hiding this comment.
no need for data-heading-link-id
Suggested change
| <h1 data-heading-link-id="379843998856" data-oe-version="2.0">Odoo for Thrift Store</h1> | |
| <h1 data-oe-version="2.0">Odoo for Thrift Store</h1> |
| @@ -0,0 +1,7 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <odoo noupdate="1"> | |||
| <record id="point_of_sale.pos_config_retail" model="pos.config" forcecreate="1"> | |||
There was a problem hiding this comment.
Don't you need to call load_onboarding_retail_scenario first? It's the scenario building this PoS
| @@ -0,0 +1,8 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <odoo noupdate="1"> | |||
| <record id="pos_session_1" model="pos.session"> | |||
|
|
||
| <function name="write" model="res.partner"> | ||
| <value model="res.partner" eval="( | ||
| obj().env.ref('base_industry_data.res_partner_35') + |
There was a problem hiding this comment.
Suggested change
| obj().env.ref('base_industry_data.res_partner_35') + | |
| obj().env.ref('base_industry_data.res_partner_35', raise_if_not_found=False) + |
| obj().env.ref('l10n_be_reports.partner_centre_de_perception_belgium') + | ||
| obj().env.ref('l10n_be_reports.partner_fps_belgium') | ||
| ).ids"/> | ||
| <value eval="{'active': False}"/> |
There was a problem hiding this comment.
Is it worth to depend on base_industry_data then?
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <odoo noupdate="1"> | |||
| <record id="resource.resource_calendar_std" model="resource.calendar" forcecreate="1"> | |||
There was a problem hiding this comment.
If forcecreate, then a name is needed
| <li> | ||
| <strong><font class="text-o-color-1">Planning:</font></strong> Organize employee schedules and shifts with ease. | ||
| </li> | ||
| </ul> |
There was a problem hiding this comment.
Missing generic message about "no custo"
| @@ -0,0 +1,14 @@ | |||
| <h2><strong>Odoo for Thrift Store</strong></h2> | |||
| <p>This industry package includes the necessary to run your thrift store business from employees'planning to sales.</p> | |||
There was a problem hiding this comment.
Suggested change
| <p>This industry package includes the necessary to run your thrift store business from employees'planning to sales.</p> | |
| <p>This industry package includes the necessary to run your thrift store business from employees' planning to sales.</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Thrift Store module: use the POS to sell products and organize with the Planning and Employees App.