[IMP] Employees: Update new employees #13050
Conversation
|
|
larm-odoo
force-pushed
the
18.0-employees-new-employee-larm
branch
from
018c92e to
d0d629a
Compare
|
Hi @slinkous - this is ready for a peer review! |
There was a problem hiding this comment.
Holy cow that is a beast of a doc! I feel like I should have an "HR Professional" certification added to my resume tab just for having read it!
All this info looks crucial. I flagged a few places that were confusing for me as a newcomer to the topic, which may or may not be useful to you.
One thing to flag is that you have a lot of content in the format of:
- :guilabel: Field: do these instructions with this field
And technically, imperative form sentences are complete sentences, so those should all start with a capital letter and end with a period according to our style guide. I see inconsistency in our docs about what we do after a colon in a list, so I think it's worth discussing.
larm-odoo
force-pushed
the
18.0-employees-new-employee-larm
branch
from
d0d629a to
b363cc5
Compare
|
Thank you for the super thorough review, @slinkous! My docs ALL used to be huge beasts! I made ONE doc for each app, then decided to chop them up and migrate them to their own docs. I used to make the craziest, longest docs =D |
|
Hi @Felicious - this is ready for a final review! |
There was a problem hiding this comment.
Thank you for all the hard work you put into updating this massive doc, @larm-odoo! 😊
We usually base points on the percentage of the doc that's been redone (this one was around 60%), but given the volume of lines changed and the improved structure and organization throughout, this deserves to be bumped up to a 5-point doc 💪 Great job!
larm-odoo
force-pushed
the
18.0-employees-new-employee-larm
branch
from
b363cc5 to
f617dd8
Compare
|
Hi @samueljlieber - this is ready for a tech review! |
Updating to new standards, and new fields. Lots of small changes to the UI requiring a new format to the sections and doc.