[IMP] Attendances: updating kiosks #13004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @slinkous - this is ready for a peer review. |
slinkous
approved these changes
Apr 23, 2025
larm-odoo
force-pushed
the
18.0-attendances-updating-kiosks-larm
branch
from
60c546a to
964d3ab
Compare
|
Hi @Felicious - this is ready for a final review =) |
Felicious
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Thanks for your work on this, @larm-odoo ! 😄
One quick note on points—since 3-point PRs are meant for more substantial updates (typically around 50–80% of the doc’s length in new or revised content. This doc has ~180 lines and the lines added was 52), this one looks closer to a 2-point scope. Would you mind updating the label to reflect that? Thank you!
larm-odoo
force-pushed
the
18.0-attendances-updating-kiosks-larm
branch
from
964d3ab to
96e7946
Compare
|
Hi @samueljlieber - this is ready for a tech review! |
samueljlieber
approved these changes
Apr 25, 2025
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2025
closes #13004 Signed-off-by: Samuel Lieber (sali) <[email protected]>
|
@larm-odoo @samueljlieber staging failed: ci/runbot on 4b5cf75138f59c22f38f5bf7bd2c21678b75d68c (view more at https://runbot.odoo.com/runbot/build/79109545) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to new formatting standards, new instructions, and new screenshots for the updated kiosk interface.