-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Inventory: Adjustments 18.0 #11930
Conversation
363ac02
to
35dc88a
Compare
@larm-odoo this is ready for peer review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the doc! I just made mostly stylistic suggestions, and therefore most of them are unnecessary. Feel free to take or leave any of them! Approving now, since everything is optional. Nice work!
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
cd299a4
to
6cd725c
Compare
Thanks Lara! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful job, @jero-odoo! The doc is comprehensive and reads well 😊
Approving with minimal comments ❤️
I also wanted to check in on a few items from the task that weren’t addressed in this PR. It’s possible they were left out intentionally, but I’d love to understand your reasoning:
- The difference between users and admins when applying inventory adjustments.
- Leave Empty vs. Set Current Value: How this affects Barcode (this could possibly be in a follow-up PR focused on Barcode. If that’s the case, just make sure to create a new task for it and assign it to the material scope so it doesn’t get overlooked!).
- Negative quantity
Let me know your thoughts, and thanks again for your great work on this!
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Outdated
Show resolved
Hide resolved
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Show resolved
Hide resolved
8b0f63b
to
c910a33
Compare
Thank you Felicia! @samueljlieber this is ready for tech review. Thanks! |
b188469
to
b03944b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo, nice work with these 18.0 updates to Inventory Adjustments! Just one mandatory fix before merge, approving!
Thank you for your work!
...
@robodoo delegate=jero-odoo
...tions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/count_products.rst
Show resolved
Hide resolved
Co-authored-by: larm-odoo <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
b03944b
to
7832ea5
Compare
@robodoo r+ |
closes #11930 Signed-off-by: Jessica Rogers (jero) <[email protected]> Co-authored-by: larm-odoo <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
Context: We received very detailed feedback from Clotilde, the BE Inventory expert, on updating the Inventory Adjustments doc for version 18.0. Liz's PR has addressed the urgent updates, so this task focuses on adding missing information and incorporating Clotilde’s context to help users better understand the Inventory Adjustment page, which serves both beginner and advanced users.
Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4435843&access_token=27ceac33-9763-4f7b-ba83-dc3f1d0bb2b3