Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Inventory: Adjustments 18.0 #11930

Closed
wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

@jero-odoo jero-odoo commented Jan 30, 2025

Context: We received very detailed feedback from Clotilde, the BE Inventory expert, on updating the Inventory Adjustments doc for version 18.0. Liz's PR has addressed the urgent updates, so this task focuses on adding missing information and incorporating Clotilde’s context to help users better understand the Inventory Adjustment page, which serves both beginner and advanced users.
Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4435843&access_token=27ceac33-9763-4f7b-ba83-dc3f1d0bb2b3

@jero-odoo jero-odoo self-assigned this Jan 30, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jan 30, 2025

Pull request status dashboard

@jero-odoo jero-odoo force-pushed the 18.0-inventory-adjustments-jero branch 3 times, most recently from 363ac02 to 35dc88a Compare February 6, 2025 15:41
@jero-odoo jero-odoo marked this pull request as ready for review February 6, 2025 15:41
@C3POdoo C3POdoo requested a review from a team February 6, 2025 15:43
@jero-odoo
Copy link
Contributor Author

@larm-odoo this is ready for peer review. Thanks!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the doc! I just made mostly stylistic suggestions, and therefore most of them are unnecessary. Feel free to take or leave any of them! Approving now, since everything is optional. Nice work!

@jero-odoo jero-odoo force-pushed the 18.0-inventory-adjustments-jero branch from cd299a4 to 6cd725c Compare February 6, 2025 17:01
@jero-odoo
Copy link
Contributor Author

Thanks Lara!
@Felicious this is ready for final review. Thank you!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful job, @jero-odoo! The doc is comprehensive and reads well 😊

Approving with minimal comments ❤️

I also wanted to check in on a few items from the task that weren’t addressed in this PR. It’s possible they were left out intentionally, but I’d love to understand your reasoning:

  • The difference between users and admins when applying inventory adjustments.
  • Leave Empty vs. Set Current Value: How this affects Barcode (this could possibly be in a follow-up PR focused on Barcode. If that’s the case, just make sure to create a new task for it and assign it to the material scope so it doesn’t get overlooked!).
  • Negative quantity

Let me know your thoughts, and thanks again for your great work on this!

@jero-odoo jero-odoo force-pushed the 18.0-inventory-adjustments-jero branch from 8b0f63b to c910a33 Compare February 6, 2025 18:54
@jero-odoo
Copy link
Contributor Author

Thank you Felicia!
In regards to the items you mentioned:
I added the "important" admonition block in the introduction to highlight the difference between admin and user rights, not sure if you saw it the first time, but in general if there is an access rights issue with a process I like to highlight it as early as possible in a doc so people don't accidentally overlook it.
I do think the barcode topic would be better handled in a different doc, I am a little concerned this one is overloaded as is.
I was not really able to think of any relevant use case for the Negative quantity, specifically why it would be utilized during a count. Lara and I both tried coming up with a few scenarios but couldn't really think of a situation where it would be useful, so it was difficult to find a place to fit that topic in the doc.

@samueljlieber this is ready for tech review. Thanks!

@jero-odoo jero-odoo requested a review from a team February 6, 2025 19:09
@jero-odoo jero-odoo force-pushed the 18.0-inventory-adjustments-jero branch 2 times, most recently from b188469 to b03944b Compare February 7, 2025 19:29
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, nice work with these 18.0 updates to Inventory Adjustments! Just one mandatory fix before merge, approving!
Thank you for your work!
...
@robodoo delegate=jero-odoo

Co-authored-by: larm-odoo <[email protected]>

Co-authored-by: Felicia Kuan <[email protected]>
@jero-odoo jero-odoo force-pushed the 18.0-inventory-adjustments-jero branch from b03944b to 7832ea5 Compare February 7, 2025 20:54
@jero-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Feb 8, 2025
closes #11930

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: larm-odoo <[email protected]>
Co-authored-by: Felicia Kuan <[email protected]>
@robodoo robodoo closed this in 7e375cf Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants